Skip to content

Commit 6085f57

Browse files
authored
Merge pull request #186 from djnalluri/fix/designate-charset
Fix designate charset logic
2 parents 7a478d4 + 333c4ef commit 6085f57

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

lib/src/core/escape/handler.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ abstract class EscapeHandler {
3535

3636
void reverseIndex();
3737

38-
void designateCharset(int charset);
38+
void designateCharset(int charset, int name);
3939

4040
void unkownEscape(int char);
4141

lib/src/core/escape/parser.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,15 @@ class EscapeParser {
161161

162162
bool _escHandleDesignateCharset0() {
163163
if (_queue.isEmpty) return false;
164-
_queue.consume();
165-
handler.designateCharset(0);
164+
int name = _queue.consume();
165+
handler.designateCharset(0, name);
166166
return true;
167167
}
168168

169169
bool _escHandleDesignateCharset1() {
170170
if (_queue.isEmpty) return false;
171-
_queue.consume();
172-
handler.designateCharset(1);
171+
int name = _queue.consume();
172+
handler.designateCharset(1, name);
173173
return true;
174174
}
175175

lib/src/terminal.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,8 +472,8 @@ class Terminal with Observable implements TerminalState, EscapeHandler {
472472
}
473473

474474
@override
475-
void designateCharset(int charset) {
476-
_buffer.charset.use(charset);
475+
void designateCharset(int charset, int name) {
476+
_buffer.charset.designate(charset, name);
477477
}
478478

479479
@override

lib/src/utils/debugger.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ class _TerminalDebuggerHandler implements EscapeHandler {
164164
}
165165

166166
@override
167-
void designateCharset(int charset) {
168-
onCommand('designateCharset($charset)');
167+
void designateCharset(int charset, int name) {
168+
onCommand('designateCharset($charset, $name)');
169169
}
170170

171171
@override

test/src/core/escape/parser_test.mocks.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,10 @@ class MockEscapeHandler extends _i1.Mock implements _i2.EscapeHandler {
143143
returnValueForMissingStub: null,
144144
);
145145
@override
146-
void designateCharset(int? charset) => super.noSuchMethod(
146+
void designateCharset(int? charset, int? name) => super.noSuchMethod(
147147
Invocation.method(
148148
#designateCharset,
149-
[charset],
149+
[charset, name],
150150
),
151151
returnValueForMissingStub: null,
152152
);

0 commit comments

Comments
 (0)