fix: update tests for data loss interface and nodesInGroup findFirst

- fleet-data tests: remove node_id/node_name, add events_discarded
- node-group tests: mock findFirst instead of findUnique for nodesInGroup

Author: TerrifiedBug

src/server/routers/__tests__/node-group.test.ts

@@ -415,7 +415,7 @@ describe("nodeGroupRouter", () => {
         makeNode({ id: "n-degraded", name: "gamma", status: "DEGRADED", labels: { region: "us-east" } }),
       ];
 
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(group as never);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(group as never);
       prismaMock.vectorNode.findMany.mockResolvedValue(nodes as never);
 
       const result = await caller.nodesInGroup({ groupId: "ng-1", environmentId: "env-1" });
@@ -432,7 +432,7 @@ describe("nodeGroupRouter", () => {
         makeNode({ id: "n-no-metrics", name: "b", nodeMetrics: [] }),
       ];
 
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(group as never);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(group as never);
       prismaMock.vectorNode.findMany.mockResolvedValue(nodes as never);
 
       const result = await caller.nodesInGroup({ groupId: "ng-1", environmentId: "env-1" });
@@ -448,7 +448,7 @@ describe("nodeGroupRouter", () => {
       const group = makeNodeGroup({ id: "ng-1", criteria: {}, requiredLabels: [] });
       const nodes = [makeNode({ id: "n-1", labels: {} })]; // no labels, but requiredLabels is empty
 
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(group as never);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(group as never);
       prismaMock.vectorNode.findMany.mockResolvedValue(nodes as never);
 
       const result = await caller.nodesInGroup({ groupId: "ng-1", environmentId: "env-1" });
@@ -466,7 +466,7 @@ describe("nodeGroupRouter", () => {
         makeNode({ id: "n-missing-role", labels: { region: "us-east" } }), // missing 'role'
       ];
 
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(group as never);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(group as never);
       prismaMock.vectorNode.findMany.mockResolvedValue(nodes as never);
 
       const result = await caller.nodesInGroup({ groupId: "ng-1", environmentId: "env-1" });
@@ -475,7 +475,7 @@ describe("nodeGroupRouter", () => {
     });
 
     it("Test 11: Throws NOT_FOUND for non-existent groupId", async () => {
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(null);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(null);
 
       await expect(
         caller.nodesInGroup({ groupId: "nonexistent", environmentId: "env-1" }),
@@ -487,7 +487,7 @@ describe("nodeGroupRouter", () => {
       const lastSeen = new Date("2026-01-15T10:00:00Z");
       const nodes = [makeNode({ id: "n-1", lastSeen })];
 
-      prismaMock.nodeGroup.findUnique.mockResolvedValue(group as never);
+      prismaMock.nodeGroup.findFirst.mockResolvedValue(group as never);
       prismaMock.vectorNode.findMany.mockResolvedValue(nodes as never);
 
       const result = await caller.nodesInGroup({ groupId: "ng-1", environmentId: "env-1" });

src/server/services/__tests__/fleet-data.test.ts

@@ -313,18 +313,16 @@ describe("getDataLoss", () => {
       {
         pipeline_id: "p1",
         pipeline_name: "ingest-logs",
-        node_id: "node-1",
-        node_name: "us-east-1",
         events_in: BigInt(1000),
-        events_out: BigInt(800), // 20% loss
+        events_out: BigInt(800),
+        events_discarded: BigInt(0), // 20% actual loss
       },
       {
         pipeline_id: "p2",
         pipeline_name: "metrics-agg",
-        node_id: "node-1",
-        node_name: "us-east-1",
         events_in: BigInt(500),
-        events_out: BigInt(490), // 2% loss
+        events_out: BigInt(490),
+        events_discarded: BigInt(0), // 2% loss
       },
     ]);
 
@@ -334,10 +332,9 @@ describe("getDataLoss", () => {
     expect(result[0]).toEqual({
       pipelineId: "p1",
       pipelineName: "ingest-logs",
-      nodeId: "node-1",
-      nodeName: "us-east-1",
       eventsIn: 1000,
       eventsOut: 800,
+      eventsDiscarded: 0,
       lossRate: 0.2,
     });
   });
@@ -347,10 +344,9 @@ describe("getDataLoss", () => {
       {
         pipeline_id: "p1",
         pipeline_name: "idle-pipeline",
-        node_id: null,
-        node_name: null,
         events_in: BigInt(0),
         events_out: BigInt(0),
+        events_discarded: BigInt(0),
       },
     ]);
 
@@ -364,10 +360,9 @@ describe("getDataLoss", () => {
       {
         pipeline_id: "p1",
         pipeline_name: "healthy",
-        node_id: "node-1",
-        node_name: "us-east-1",
         events_in: BigInt(1000),
-        events_out: BigInt(999), // 0.1% loss
+        events_out: BigInt(999),
+        events_discarded: BigInt(0), // 0.1% loss
       },
     ]);
 
@@ -381,18 +376,16 @@ describe("getDataLoss", () => {
       {
         pipeline_id: "p1",
         pipeline_name: "moderate-loss",
-        node_id: "node-1",
-        node_name: "us-east-1",
         events_in: BigInt(1000),
-        events_out: BigInt(850), // 15% loss
+        events_out: BigInt(850),
+        events_discarded: BigInt(0), // 15% loss
       },
       {
         pipeline_id: "p2",
         pipeline_name: "severe-loss",
-        node_id: "node-1",
-        node_name: "us-east-1",
         events_in: BigInt(1000),
-        events_out: BigInt(500), // 50% loss
+        events_out: BigInt(500),
+        events_discarded: BigInt(0), // 50% loss
       },
     ]);