Merge pull request #19 from Tiime-Software/remove-legacy-code

Remove legacy code

Author: odolbeau

src/RouteStorage/FileRouteStorage.php

@@ -40,10 +40,12 @@ public function getRoutes(): array
         foreach ($routes as $route) {
             $parts = explode('|', $route);
 
+            if (2 !== \count($parts)) {
+                throw new \RuntimeException("It looks like the given file ({$this->file}) does not contains valid data. Consider removing it.");
+            }
+
             $name = $parts[0];
-            // In order to avoid BC break, we consider a route without a status code as a 200 OK.
-            // To be removed in 2.0
-            $statusCode = (int) ($parts[1] ?? 200);
+            $statusCode = (int) $parts[1];
 
             if (!\array_key_exists($name, $filteredRoutes)) {
                 $filteredRoutes[$name] = [$statusCode];

tests/RouteStorage/FileRouteStorageTest.php

@@ -24,15 +24,4 @@ public function testStorage(): void
             'route3' => [403],
         ], $storage->getRoutes());
     }
-
-    public function testWithStorageWithoutStatusCode(): void
-    {
-        $storage = new FileRouteStorage(__DIR__.'/../Fixtures/file_containing_one_route_per_row_with_duplicates');
-
-        $this->assertSame([
-            'route1' => [200, 200],
-            'route2' => [200, 200, 200],
-            'route3' => [200, 200],
-        ], $storage->getRoutes());
-    }
 }