Skip to content

Commit 200a6ff

Browse files
committed
Include more inline comments
1 parent 23a49e9 commit 200a6ff

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

.github/workflows/nightly.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ env:
1717
go: "1.18"
1818

1919
jobs:
20+
# Quick build using nightly libtiledb installed as conda binary
21+
# https://anaconda.org/tiledb/tiledb/files?channel=nightlies
22+
# https://github.com/TileDB-Inc/conda-forge-nightly-controller
2023
ubuntu:
2124
runs-on: ubuntu-20.04
2225
defaults:
@@ -48,6 +51,17 @@ jobs:
4851
4952
go test -v ./...
5053
54+
# Longer build because libtiledb is built from source
55+
#
56+
# Couldn't build against the conda binary on macOS. When I set
57+
# `DYLD_LIBRARY_PATH=$CONDA_PREFIX/lib`, then it failed because it found the
58+
# system libarchive instead of the conda-installed one (even when I explicitly
59+
# installed it from conda-forge). Error message below:
60+
#
61+
# dyld: Symbol not found: _iconv
62+
# Referenced from: /usr/lib/libarchive.2.dylib
63+
# Expected in: /Users/runner/micromamba-root/envs/nightly/lib/libiconv.2.dylib
64+
# in /usr/lib/libarchive.2.dylib
5165
macos:
5266
runs-on: macos-11
5367
needs: ubuntu
@@ -72,6 +86,12 @@ jobs:
7286
- name: Test TileDB-Go
7387
run: go test -v ./...
7488

89+
# Report if either the Ubuntu or macOS builds fail
90+
#
91+
# If there is an existing "nightly-failure" Issue open, then it comments
92+
# instead of creating a new one
93+
#
94+
# Only reports a failure for scheduled builds on the TileDB-Inc repo
7595
issue:
7696
permissions:
7797
issues: write

0 commit comments

Comments
 (0)