Skip to content

Commit 16687d5

Browse files
committed
fix: stack overflow error when generating hashes
This can happen if a rule ends up depending on itself. To check for this we simply avoid trying to create a digest for a rule of the same name as the current one we're working on. Fixes: #71
1 parent d01cb84 commit 16687d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/java/com/bazel_diff/TargetHashingClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ private byte[] createDigestForRule(
8989
digest.update(ruleInput.getBytes());
9090
BazelRule inputRule = allRulesMap.get(ruleInput);
9191
byte[] sourceFileDigest = getDigestForSourceTargetName(ruleInput, bazelSourcefileTargets);
92-
if (inputRule != null) {
92+
if (inputRule != null && !inputRule.getName().equals(rule.getName())) {
9393
byte[] ruleInputHash = createDigestForRule(
9494
inputRule,
9595
allRulesMap,

0 commit comments

Comments
 (0)