Merge pull request #21 from Tinder/testonly_deps

Move junit and mockito to testonly maven deps

Author: tinder-maxwellelliott

README.md

@@ -182,11 +182,11 @@ Add the following to your `WORKSPACE` file to add the external repositories, rep
     )
 
     load("@bazel_diff//:repositories.bzl", "bazel_diff_dependencies")
-    load("@bazel_diff//:constants.bzl", "BAZEL_DIFF_MAVEN_ARTIFACTS")
 
     bazel_diff_dependencies()
 
     load("@rules_jvm_external//:defs.bzl", "maven_install")
+    load("//:artifacts.bzl", "BAZEL_DIFF_MAVEN_ARTIFACTS")
 
     maven_install(
         name = "bazel_diff_maven",

WORKSPACE

@@ -1,7 +1,6 @@
 workspace(name = "bazel_diff")
 
 load("//:repositories.bzl", "bazel_diff_dependencies")
-load("//:constants.bzl", "BAZEL_DIFF_MAVEN_ARTIFACTS")
 
 bazel_diff_dependencies()
 
@@ -11,6 +10,7 @@ rules_proto_dependencies()
 rules_proto_toolchains()
 
 load("@rules_jvm_external//:defs.bzl", "maven_install")
+load("//:artifacts.bzl", "BAZEL_DIFF_MAVEN_ARTIFACTS")
 
 maven_install(
     name = "bazel_diff_maven",

artifacts.bzl

@@ -0,0 +1,11 @@
+""" Artifacts used to build bazel-diff """
+
+load("@rules_jvm_external//:specs.bzl", "maven")
+
+BAZEL_DIFF_MAVEN_ARTIFACTS = [
+    maven.artifact("junit", "junit", "4.13", testonly = True),
+    maven.artifact("org.mockito", "mockito-core", "3.5.15", testonly = True),
+    "info.picocli:picocli:jar:4.3.2",
+    "com.google.code.gson:gson:jar:2.8.6",
+    "com.google.guava:guava:29.0-jre"
+]

constants.bzl

@@ -7,11 +7,3 @@ DEFAULT_JVM_EXTERNAL_TAG = "3.3"
 RULES_JVM_EXTERNAL_SHA = "d85951a92c0908c80bd8551002d66cb23c3434409c814179c0ff026b53544dab"
 
 BUILD_PROTO_MESSAGE_SHA = "50b79faec3c4154bed274371de5678b221165e38ab59c6167cc94b922d9d9152"
-
-BAZEL_DIFF_MAVEN_ARTIFACTS = [
-    "junit:junit:4.12",
-    "org.mockito:mockito-core:3.3.3",
-    "info.picocli:picocli:jar:4.3.2",
-    "com.google.code.gson:gson:jar:2.8.6",
-    "com.google.guava:guava:29.0-jre"
-]

repositories.bzl

@@ -3,7 +3,7 @@ Methods to assist in loading dependencies for bazel-diff in WORKSPACE files
 """
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-load("//:constants.bzl", "DEFAULT_JVM_EXTERNAL_TAG", "RULES_JVM_EXTERNAL_SHA", "BUILD_PROTO_MESSAGE_SHA")
+load("//:constants.bzl", "DEFAULT_JVM_EXTERNAL_TAG", "RULES_JVM_EXTERNAL_SHA")
 
 def _maybe(repo_rule, name, **kwargs):
     if not native.existing_rule(name):

test/java/com/bazel_diff/BUILD

@@ -13,5 +13,6 @@ java_library(
         "//src/main/java/com/bazel_diff:java-bazel-diff-lib",
         "@bazel_diff_maven//:org_mockito_mockito_core",
         "@bazel_diff_maven//:junit_junit"
-    ]
+    ],
+    testonly = True
 )