Skip to content

bug: validate.rs deleted — breaking public API + removes path traversal protection #247

@aphoristicartist

Description

@aphoristicartist

Context

PR #242 deletes engine/src/validate.rs and its pub use validate::validate_safe_output_path re-export from lib.rs. This function provides path traversal protection and is needed by both the CLI and the new side_inference module.

Impact

  • Breaking public API for any downstream consumer of infiniloom_engine
  • side_inference/mod.rs:96-107 has a path traversal vulnerability in find_manifest_for_file that this function could protect against
  • install.rs writes to arbitrary paths without validation

Suggested Fix

  • Restore validate.rs or move to CLI crate
  • Apply path validation in find_manifest_for_file and install.rs

Files

  • engine/src/lib.rs
  • engine/src/validate.rs (deleted)
  • engine/src/side_inference/mod.rs:96-107
  • cli/src/commands/install.rs

Severity

High

Found during review of #242

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecuritySecurity scanning

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions