Merge pull request #14 from TransitApp/better_default_value_for_duration_modifierx

set duration modifiers to a better default

Author: JMilot1

gtfs_loader/schema.py

@@ -231,10 +231,10 @@ class StopTime(Entity):
     end_pickup_drop_off_window: GTFSTime = GTFSTime('')
     pickup_type: PickupType = PickupType.REGULARLY_SCHEDULED
     drop_off_type: DropOffType = DropOffType.REGULARLY_SCHEDULED
-    mean_duration_factor: float = -1
-    mean_duration_offset: float = -1
-    safe_duration_factor: float = -1
-    safe_duration_offset: float = -1
+    mean_duration_factor: Optional[float] = None
+    mean_duration_offset: Optional[float] = None
+    safe_duration_factor: Optional[float] = None
+    safe_duration_offset: Optional[float] = None
 
     @property
     def stop(self):

setup.py

@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages
 
 setup(name='py-gtfs-loader',
-      version='0.1.7',
+      version='0.1.8',
       description='Load GTFS',
       url='https://github.com/TransitApp/py-gtfs-loader',
       author='Nicholas Paun, Jonathan Milot',

tests/test_unmodified/expected_default/stop_times.txt

@@ -1,16 +1,16 @@
 trip_id,stop_sequence,stop_id,arrival_time,departure_time,start_pickup_drop_off_window,end_pickup_drop_off_window,pickup_type,drop_off_type,mean_duration_factor,mean_duration_offset,safe_duration_factor,safe_duration_offset
-trip_1,0,junction,22:00:00,22:00:00,,,0,0,-1,-1,-1,-1
-trip_1,1,slocan-park,22:01:00,22:01:00,,,0,0,-1,-1,-1,-1
-trip_1,2,slocan-city,22:02:00,22:02:00,,,0,0,-1,-1,-1,-1
-trip_1,3,nelson-tc,22:03:00,22:03:00,,,0,0,-1,-1,-1,-1
-trip_1,4,junction,22:04:00,22:04:00,,,0,0,-1,-1,-1,-1
-trip_2,0,junction,22:04:00,22:04:00,,,0,0,-1,-1,-1,-1
-trip_2,1,slocan-park,22:05:00,22:05:00,,,0,0,-1,-1,-1,-1
-trip_2,2,slocan-city,22:06:00,22:06:00,,,0,0,-1,-1,-1,-1
-trip_2,3,nelson-tc,22:07:00,22:07:00,,,0,0,-1,-1,-1,-1
-trip_2,4,junction,22:08:00,22:08:00,,,0,0,-1,-1,-1,-1
-trip_3,0,junction,22:08:00,22:08:00,,,0,0,-1,-1,-1,-1
-trip_3,1,slocan-park,22:09:00,22:09:00,,,0,0,-1,-1,-1,-1
-trip_3,2,slocan-city,22:10:00,22:10:00,,,0,0,-1,-1,-1,-1
-trip_3,3,nelson-tc,22:11:00,22:11:00,,,0,0,-1,-1,-1,-1
-trip_3,4,junction,22:12:00,22:12:00,,,0,0,-1,-1,-1,-1
+trip_1,0,junction,22:00:00,22:00:00,,,0,0,,,,
+trip_1,1,slocan-park,22:01:00,22:01:00,,,0,0,,,,
+trip_1,2,slocan-city,22:02:00,22:02:00,,,0,0,,,,
+trip_1,3,nelson-tc,22:03:00,22:03:00,,,0,0,,,,
+trip_1,4,junction,22:04:00,22:04:00,,,0,0,,,,
+trip_2,0,junction,22:04:00,22:04:00,,,0,0,,,,
+trip_2,1,slocan-park,22:05:00,22:05:00,,,0,0,,,,
+trip_2,2,slocan-city,22:06:00,22:06:00,,,0,0,,,,
+trip_2,3,nelson-tc,22:07:00,22:07:00,,,0,0,,,,
+trip_2,4,junction,22:08:00,22:08:00,,,0,0,,,,
+trip_3,0,junction,22:08:00,22:08:00,,,0,0,,,,
+trip_3,1,slocan-park,22:09:00,22:09:00,,,0,0,,,,
+trip_3,2,slocan-city,22:10:00,22:10:00,,,0,0,,,,
+trip_3,3,nelson-tc,22:11:00,22:11:00,,,0,0,,,,
+trip_3,4,junction,22:12:00,22:12:00,,,0,0,,,,