From 2eeff079f82f53f8d718815b10f10f46a087c284 Mon Sep 17 00:00:00 2001 From: Makan Azarshahy Date: Thu, 29 Mar 2018 10:19:25 -0700 Subject: [PATCH 1/4] Changed names of bundles to follow team naming convention --- src/nodeServer/app.js | 2 +- webpack.config.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nodeServer/app.js b/src/nodeServer/app.js index 77a372e..ec506cc 100644 --- a/src/nodeServer/app.js +++ b/src/nodeServer/app.js @@ -15,7 +15,7 @@ const app = http.createServer((request, response) => { if (method === 'GET') { if (base === '') { serveHtml(request, response); - } else if (base === 'bundle.js' || base === 'bundle-server.js') { + } else if (base === 'MenuView-bundle.js' || base === 'MenuView-bundle-server.js') { serveBundle(request, response, base); } else if (base === 'restaurants' && menu === 'menu' && !tag) { const itemInfo = [restuarantName, meal]; diff --git a/webpack.config.js b/webpack.config.js index 47d43b5..ab0f78d 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -27,7 +27,7 @@ const clientSide = { }, output: { path: BUILD_DIR, - filename: 'bundle.js', + filename: 'MenuView-bundle.js', }, } // style-loader! @@ -48,7 +48,7 @@ const serverSide = { ], }, output: { - filename: 'bundle-server.js', + filename: 'Menu-View-bundle-server.js', path: path.resolve(__dirname, 'src/public'), libraryTarget: 'commonjs-module', publicPath: '/' From a3752ec7a58f5414b9d66d6154daa3e707e1d2bf Mon Sep 17 00:00:00 2001 From: Makan Azarshahy Date: Thu, 29 Mar 2018 10:49:31 -0700 Subject: [PATCH 2/4] Changed script for bundle to hit correct path --- src/client/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/index.html b/src/client/index.html index fd3d784..ffc280b 100644 --- a/src/client/index.html +++ b/src/client/index.html @@ -21,7 +21,7 @@ - + - +