Removing eyeglass support has broken import

[ashleynolan]

@mrmartineau Only just noticed this as I went to put in a bugfix – didn't realise you had removed eyeglass support. This is quite a big breaking change, definitely not a patch release 😉(it will break how we pull it in as part of the JE SCSS setup).

What was the reason for removing? If this is something that you think needs to happen, would be worth reverting and major version bumping and I can then fork off the minor branch.

[ashleynolan]

Looking at this again – looks like it was just the eyeglass imports within the module that were removed. Is that right?

Was this to make it more compatible with certain use-cases?

Also, would be good if we could have a PR system for kickoff modules like this and the utils – helps in terms of seeing the changes that is going into the repo and keeps the history much cleaner as can squash commits together (no commits that are just version bumps then).

[mrmartineau]

Hey @ashleynolan, apologies for the breaking change. It should have been highlighted/PR'd.. I did not stop this package from being used as an Eyeglass package, but I changed how the sub-dependencies were referenced because this only would have worked if Eyeglass was being used on the user's particular project. Does that make sense?

See b800d77 and more specifically:

kickoff-grid.css/scss/index.scss

Lines 12 to 17 in b800d77

	@import "../../utils.scss/scss/index"; // https://github.com/TryKickoff/kickoff-utils.scss
	/* Import Grid helpers and mixins */
	@import 'grid-variables';
	@import "../../../include-media/dist/include-media"; // http://include-media.com
	@import 'grid-helpers';

Do those paths not work for you?