From 510ec85a98d4eb7154ba943015de8a8be55107f4 Mon Sep 17 00:00:00 2001 From: Razvan Savu Date: Thu, 6 Aug 2020 12:24:01 +0300 Subject: [PATCH 1/4] Fix order of initialization --- package.json | 2 +- typingdnaclient.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 8193247..24830a0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "typingdnaclient", - "version": "1.0.5", + "version": "1.0.6", "description": "Basic nodeJs implementation for the TypingDNA.com Auth API", "main": "typingdnaclient.js", "scripts": { diff --git a/typingdnaclient.js b/typingdnaclient.js index 91421f1..c33ed0b 100644 --- a/typingdnaclient.js +++ b/typingdnaclient.js @@ -215,6 +215,10 @@ TypingDNAClient.prototype.delete = function(options, callback) { **/ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, options, callback) { + if(typeof options === 'function') { + callback = options; + options = {} + } if(typeof userId !== 'string' || userId.replace(/\s/g,'').length < 6) { return callback && callback(new Error('Invalid user id.'), null); } @@ -224,10 +228,6 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti if(typeof quality !== 'number') { quality = 2; } - if(typeof options === 'function') { - callback = options; - options = {} - } this.makeRequest({ path: '/verify/'+ encodeURIComponent(userId), From 59dbdf62f42651edc036b9e7b1468f829e5336c1 Mon Sep 17 00:00:00 2001 From: razvan Date: Thu, 6 Aug 2020 17:09:35 +0300 Subject: [PATCH 2/4] Add extra params on response from verify() --- package.json | 2 +- typingdnaclient.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 24830a0..c3550c3 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "typingdnaclient", - "version": "1.0.6", + "version": "1.0.7", "description": "Basic nodeJs implementation for the TypingDNA.com Auth API", "main": "typingdnaclient.js", "scripts": { diff --git a/typingdnaclient.js b/typingdnaclient.js index c33ed0b..256be4e 100644 --- a/typingdnaclient.js +++ b/typingdnaclient.js @@ -243,6 +243,7 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti } var resObj = { message: response['message'], + message_code: parseInt(response['message_code']), success: response['success'] || 0, statusCode: parseInt(response['status']) } @@ -252,7 +253,7 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti if(response['device_similarity'] !== undefined) { resObj['deviceSimilarity'] = Math.round(response['device_similarity']); } if(response['confidence_interval'] !== undefined) { resObj['confidence'] = Math.round(response['confidence_interval']); } if(response['confidence'] !== undefined) { resObj['netConfidence'] = Math.round(response['confidence']); } - + if(response['positions'] !== undefined) { resObj['positions'] = response['positions']; } callback && callback(error, resObj); }) }; From d1902bc005a0e7e97144750c547cc9ea9e314110 Mon Sep 17 00:00:00 2001 From: razvan Date: Thu, 6 Aug 2020 17:27:50 +0300 Subject: [PATCH 3/4] Update version --- package-lock.json | 5 +++++ package.json | 2 +- typingdnaclient.js | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 package-lock.json diff --git a/package-lock.json b/package-lock.json new file mode 100644 index 0000000..d944ec2 --- /dev/null +++ b/package-lock.json @@ -0,0 +1,5 @@ +{ + "name": "typingdnaclient", + "version": "1.0.7", + "lockfileVersion": 1 +} diff --git a/package.json b/package.json index c3550c3..24830a0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "typingdnaclient", - "version": "1.0.7", + "version": "1.0.6", "description": "Basic nodeJs implementation for the TypingDNA.com Auth API", "main": "typingdnaclient.js", "scripts": { diff --git a/typingdnaclient.js b/typingdnaclient.js index 256be4e..4123df0 100644 --- a/typingdnaclient.js +++ b/typingdnaclient.js @@ -1,7 +1,7 @@ /** * NodeJs implementation for the TypingDNA.com Auth API. * - * @version 1.0.5 + * @version 1.0.6 * * @author Stefan Endres * @copyright TypingDNA.com, SC TypingDNA SRL From 24b1c24814fb7cc357371f59f14bb9e2de958c43 Mon Sep 17 00:00:00 2001 From: razvan Date: Fri, 7 Aug 2020 11:56:57 +0300 Subject: [PATCH 4/4] Update returned api params --- typingdnaclient.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/typingdnaclient.js b/typingdnaclient.js index 4123df0..b8315ea 100644 --- a/typingdnaclient.js +++ b/typingdnaclient.js @@ -87,6 +87,7 @@ TypingDNAClient.prototype.save = function(userId, typingPattern, callback) { } callback && callback(error, { message: response['message'], + message_code: response['message_code'], success: response['success'] || 0, statusCode: parseInt(response['status']) }); @@ -94,6 +95,8 @@ TypingDNAClient.prototype.save = function(userId, typingPattern, callback) { }; /** + * TODO Update doc + * * Check user method for verifying how many previous recordings you have for a user * Usage: typingDnaClient.check(userData, callback); * @@ -141,6 +144,7 @@ TypingDNAClient.prototype.check = function(options, callback) { } callback && callback(error, { message: response['message'], + message_code: response['message_code'], success: response['success'] || 0, count: response['count'], mobilecount: response['mobilecount'], @@ -195,6 +199,7 @@ TypingDNAClient.prototype.delete = function(options, callback) { } callback && callback(error, { message: response['message'], + message_code: response['message_code'], success: response['success'] || 0, result: response['deleted'], statusCode: parseInt(response['status']) @@ -254,6 +259,8 @@ TypingDNAClient.prototype.verify = function(userId, typingPattern, quality, opti if(response['confidence_interval'] !== undefined) { resObj['confidence'] = Math.round(response['confidence_interval']); } if(response['confidence'] !== undefined) { resObj['netConfidence'] = Math.round(response['confidence']); } if(response['positions'] !== undefined) { resObj['positions'] = response['positions']; } + if(response['previous_samples'] !== undefined) { resObj['previous_samples'] = response['previous_samples']; } + if(response['compared_samples'] !== undefined) { resObj['compared_samples'] = response['compared_samples']; } callback && callback(error, resObj); }) }; @@ -301,6 +308,7 @@ TypingDNAClient.prototype.match = function(typingPattern1, typingPattern2, quali } var resObj = { message: response['message'], + message_code: response['message_code'], success: response['success'] || 0, statusCode: parseInt(response['status']) }