-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Issue: In Solweig all output is now saved as float 64. For many variables this doesn't seem to make much sense: Tmrt, Kup, Kdown, Lup, Ldown. Using float32 would be probably OK for these variables. An advantage is that outputfiles of float32 are only half the size of float64 files (resulting in faster I/O, less storage).
Proposed solution: An obvious place to do this conversion seems to be in ./umep/functions/SOLWEIGpython/solweig_runner.py -> class SolweigRun -> method run(). Toward the end of this method (line 630 and further), the function common.save_raster() is called a couple of times to write the raster Tmrt, Tmrt_avg, , ... This could be replaced by Tmrt.astype(np.float32).
Remarks:
- maybe downstream umep modules require these file to be in float64.
- maybe it would be even more efficient to move the dtype-conversion earlier in the processing, so that other parts of the code also profit.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request