Add KEYIMAGE_SIZE constant

This is pretty universal and may be helpful in other areas of the code.

Author: mimirmim

src/core_write.cpp

@@ -285,7 +285,7 @@ void TxToUniv(const CTransaction& tx, const uint256& hashBlock, UniValue& entry,
             UniValue arrKeyImages(UniValue::VARR);
             for (unsigned int k = 0; k < nSigInputs; k++) {
                 UniValue objKeyImage(UniValue::VOBJ);
-                objKeyImage.pushKV(std::to_string(k), HexStr(&vKeyImages[k*33], &vKeyImages[(k*33)+33])); // TODO: add in constant
+                objKeyImage.pushKV(std::to_string(k), HexStr(&vKeyImages[k*KEYIMAGE_SIZE], &vKeyImages[(k*KEYIMAGE_SIZE)+KEYIMAGE_SIZE])); // TODO: add in constant
                 arrKeyImages.push_back(objKeyImage);
             }
             in.pushKV("key_images", arrKeyImages);
@@ -378,7 +378,7 @@ void TxToUniv(const CTransaction& tx, const uint256& hashBlock, UniValue& entry,
             UniValue arrKeyImages(UniValue::VARR);
             for (unsigned int k = 0; k < nSigInputs; k++) {
                 UniValue objKeyImage(UniValue::VOBJ);
-                objKeyImage.pushKV(std::to_string(k), HexStr(&vKeyImages[k*33], &vKeyImages[(k*33)+33])); // TODO: add in constant
+                objKeyImage.pushKV(std::to_string(k), HexStr(&vKeyImages[k*KEYIMAGE_SIZE], &vKeyImages[(k*KEYIMAGE_SIZE)+KEYIMAGE_SIZE])); // TODO: add in constant
                 arrKeyImages.push_back(objKeyImage);
             }
             in.pushKV("key_images", arrKeyImages);

src/veil/ringct/anon.h

@@ -10,14 +10,12 @@
 class CTxMemPool;
 class CValidationState;
 
+const size_t KEYIMAGE_SIZE = 33;
 const size_t MIN_RINGSIZE = 3;
 const size_t MAX_RINGSIZE = 32;
-
 const size_t MAX_ANON_INPUTS = 32; // To raise see MLSAG_MAX_ROWS also
-
 const size_t ANON_FEE_MULTIPLIER = 2;
 
-
 bool VerifyMLSAG(const CTransaction &tx, CValidationState &state);
 
 bool AddKeyImagesToMempool(const CTransaction &tx, CTxMemPool &pool);