RPC Calls Need to be Checked and Fixed for RingCT Integration

[CaveSpectre11]

Short Description

A number of RPC commands need to be checked for Ring CT Integration.

Detailed Description

@4x13 has flagged a number of RPC calls that are likely to have issues with RingCT. They need to individually be evaluated and any issues corrected. These may be split into separate issues, but until the individual details are known about each one, this will serve as a placeholder.

• createrawtransaction - new code for RingCT
• createrawbasecointransaction - move the code from createrawtransaction for the interim.
• createrawcttransaction - move the code from createrawbasecointransaction for the interim.
• decoderawtransaction - @mimirmim - [WIP][RPC] RingCT output overhaul #688
• getblock - @mimirmim - [WIP][RPC] RingCT output overhaul #688
• fundrawtransaction
• fundrawcttransaction
• fundrawbasecointransaction
• getblockchaininfo - @codeofalltrades - no change
• getnetworkinfo - @codeofalltrades - no change
• getinfo - Obsolete in bitcoin core version 0.16.0 use getblockchaininfo, getnetworkinfo, or getwalletinfo
• getblockhash
• getnewaddress - @codeofalltrades
• getrawmempool [in verbose mode]
• getrawtransaction - @mimirmim - [WIP][RPC] RingCT output overhaul #688
• gettransaction - @mimirmim
• gettxout - @CaveSpectre11
• listunspent - @CaveSpectre11 - [RPC] correct listunspent for ct, ringct and zerocoin #696
• sendrawtransaction - new code for RingCT.
• sendrawcttransaction - move the code from createrawbasecointransaction for the interim.
• sendrawbasecointransaction - move the code from sendrawtransaction for the interim.
• signmessage
• signrawtransaction
• signrawtransactionwithwallet
• verifymessage

[mimirmim]

I had done some work on this with #688.

This has enabled the following to be updated:
getrawtransaction
decoderawtransaction
getblock

gettransaction additionally had the debug: section removed.

[mimirmim]

createrawtransaction is basecoin.
createrawbasecointransaction is actually for CT.

Need to change:

• createrawtransaction new code for RingCT.
• createrawcttransaction move the code from createrawbasecointransaction for the interim.
• createrawbasecointransaction move the code from createrawtransaction for the interim.

[mimirmim]

These also need to be added / changed:

• fundrawtransaction
• fundrawcttransaction
• fundrawbasecointransaction

fundrawtransactionfrom kind of does the above.

[mimirmim]

Looks like this only works for basecoin so variants need to be created too:

• sendrawtransaction
• sendrawcttransaction
• sendrawbasecointransaction

[mimirmim]

sendrawtransaction only goes to user mempool. Needs fix asap.