PHP8.4 (#528)

* Added 8.4 to fire in matrix versions

* PHP8.4 nullcheck fixes

* phpstan checks

Author: SecondeJK

.github/workflows/build.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php: ['8.1', '8.2', '8.3']
+        php: ['8.1', '8.2', '8.3', '8.4']
 
     name: PHP ${{ matrix.php }} Test
 

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php: [ '8.1', '8.2', '8.3' ]
+        php: [ '8.1', '8.2', '8.3', '8.4' ]
 
     name: PHP ${{ matrix.php }} Test
 

src/Account/Config.php

@@ -19,9 +19,9 @@ class Config implements
     public function __construct(
         ?string $sms_callback_url = null,
         ?string $dr_callback_url = null,
-        int|string $max_outbound_request = null,
-        int|string $max_inbound_request = null,
-        int|string $max_calls_per_second = null
+        int|string|null $max_outbound_request = null,
+        int|string|null $max_inbound_request = null,
+        int|string|null $max_calls_per_second = null
     ) {
         if (!is_null($sms_callback_url)) {
             $this->data['sms_callback_url'] = $sms_callback_url;

src/Client.php

@@ -231,7 +231,13 @@ public function __construct(
         // Disable throwing E_USER_DEPRECATED notices by default, the user can turn it on during development
         if (array_key_exists('show_deprecations', $this->options) && ($this->options['show_deprecations'] == true)) {
             set_error_handler(
-                static fn (int $errno, string $errstr, string $errfile = null, int $errline = null, array $errorcontext = null) => true,
+                static fn (
+                    int $errno,
+                    string $errstr,
+                    ?string $errfile = null,
+                    ?int $errline = null,
+                    ?array $errorcontext = null
+                ) => true,
                 E_USER_DEPRECATED
             );
         }

src/Client/Exception/Validation.php

@@ -11,7 +11,7 @@ class Validation extends Request
     public function __construct(
         string $message = '',
         int $code = 0,
-        Throwable $previous = null,
+        ?Throwable $previous = null,
         private readonly array $errors = []
     ) {
         parent::__construct($message, $code, $previous);

src/Conversation/Client.php

@@ -30,8 +30,9 @@ public function getAPIResource(): APIResource
         return $this->api;
     }
 
-    public function listConversations(ListConversationFilter $conversationFilter = null): IterableAPICollection
-    {
+    public function listConversations(
+        ?ListConversationFilter $conversationFilter = null
+    ): IterableAPICollection {
         if (!$conversationFilter) {
             $conversationFilter = new ListConversationFilter();
         }

src/Meetings/Client.php

@@ -90,7 +90,7 @@ public function updateRoom(string $id, array $payload): Room
         return $room;
     }
 
-    public function getAllListedRooms(string $start_id = null, string $end_id = null, int $size = 20): array
+    public function getAllListedRooms(?string $start_id = null, ?string $end_id = null, int $size = 20): array
     {
         $filterParams = [];
 
@@ -233,7 +233,7 @@ public function updateTheme(string $id, array $payload): ?ApplicationTheme
         return $applicationTheme;
     }
 
-    public function getRoomsByThemeId(string $themeId, string $startId = null, string $endId = null, int $size = 20): array
+    public function getRoomsByThemeId(string $themeId, ?string $startId = null, ?string $endId = null, int $size = 20): array
     {
         $this->api->setIsHAL(true);
         $this->api->setCollectionName('rooms');

src/Numbers/Client.php

@@ -106,7 +106,7 @@ public function get(string $number): Number
      * @throws ClientException\Request
      * @throws ClientException\Server
      */
-    public function searchAvailable(string $country, FilterInterface $options = null): array
+    public function searchAvailable(string $country, ?FilterInterface $options = null): array
     {
         if (is_null($options)) {
             $options = new AvailableNumbers([
@@ -134,7 +134,7 @@ public function searchAvailable(string $country, FilterInterface $options = null
      * @throws ClientException\Request
      * @throws ClientException\Server
      */
-    public function searchOwned($number = null, FilterInterface $options = null): array
+    public function searchOwned($number = null, ?FilterInterface $options = null): array
     {
         if ($number !== null) {
             if ($options !== null) {

src/Subaccount/Client.php

@@ -86,7 +86,7 @@ public function updateSubaccount(string $apiKey, string $subaccountApiKey, Accou
         return $this->api->partiallyUpdate($apiKey . '/subaccounts/' . $subaccountApiKey, $account->toArray());
     }
 
-    public function getCreditTransfers(string $apiKey, FilterInterface $filter = null): mixed
+    public function getCreditTransfers(string $apiKey, ?FilterInterface $filter = null): mixed
     {
         if (!$filter) {
             $filter = new EmptyFilter();
@@ -101,7 +101,7 @@ public function getCreditTransfers(string $apiKey, FilterInterface $filter = nul
         return array_map(fn ($item) => $hydrator->hydrate($item), $transfers);
     }
 
-    public function getBalanceTransfers(string $apiKey, FilterInterface $filter = null): mixed
+    public function getBalanceTransfers(string $apiKey, ?FilterInterface $filter = null): mixed
     {
         if (!$filter) {
             $filter = new EmptyFilter();

src/Users/Client.php

@@ -29,7 +29,7 @@ public function getApiResource(): APIResource
         return $this->api;
     }
 
-    public function listUsers(FilterInterface $filter = null): IterableAPICollection
+    public function listUsers(?FilterInterface $filter = null): IterableAPICollection
     {
         if (is_null($filter)) {
             $filter = new EmptyFilter();