Skip to content

build: Refactor how components are created/tested #604

@catamorphism

Description

@catamorphism

On #599, @alexcrichton suggested:

  • Refactor how components are created/tested
    Previously wasm-tools component new was executed, but that predates a lot of bits and pieces today so I'd drop that entirely as well as the whole *.core.wasm and *.component.wasm distinction, nowadays we should only emit *.wasm.
    For wasip2 testing clang will complain that it can't execute wasm-component-ld (which internally does basically what wasm-tools component new does). For that you can arrange for wasm-component-ld to be installed on the builder (e.g. cargo install wasm-component-ld@VERSION, or something similar)

For the component-ld bits, if you're willing, my goal is to get the testing pretty close to what the toolchain does "for real" in the wasi-sdk artifacts which is to use wasm-component-ld to produce a component natively. If you'd prefer though I can also work on said refactoring if it's not clear how to apply it.


We agreed to land the PR without this change; filing an issue so that I or someone else can do it in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions