Skip to content

Commit 2c8f8cd

Browse files
committed
fix lint issues
1 parent e57b016 commit 2c8f8cd

File tree

2 files changed

+44
-51
lines changed

2 files changed

+44
-51
lines changed

eslint.config.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ export default [
55
languageOptions: {
66
globals: {
77
node: true,
8-
es6: true
8+
es6: true,
9+
URL: "readonly"
910
},
1011
parserOptions: {
1112
ecmaVersion: 'latest',
@@ -22,5 +23,8 @@ export default [
2223
'unicorn/prefer-spread': 0
2324
}
2425
},
26+
{
27+
ignores: ["test/*"]
28+
},
2529
js.configs.recommended
2630
];

lib/harAnalyzer.js

Lines changed: 39 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export class HarAnalyzer {
6969
for (const htmlObj of data.htmls) {
7070
const dom = new JSDOM(htmlObj.content);
7171
const styleElements = dom.window.document.querySelectorAll('script');
72-
styleElements.forEach((styleElement, index) => {
72+
styleElements.forEach((styleElement) => {
7373
const styleElementObj = {
7474
'url': htmlObj.url,
7575
'content': styleElement.textContent,
@@ -103,55 +103,44 @@ export class HarAnalyzer {
103103
return knowledgeData;
104104
}
105105

106-
try {
107-
// Lint with both security and standard configurations
108-
const lintPromises = analyzedData['all-scripts'].flatMap(entry => [
109-
this.eslintSecurity.lintText(entry.content).then(results => {
110-
return results.flatMap(result =>
111-
result.messages
112-
.filter(message => message.ruleId !== null) // Ignore messages with null ruleId
113-
.map(message => ({
114-
url: entry.url,
115-
rule: message.ruleId,
116-
category: 'security',
117-
severity: message.severity === 1 ? "warning" : message.severity === 2 ? "error" : message.severity,
118-
text: message.message,
119-
line: message.line,
120-
column: message.column
121-
}))
122-
);
123-
}),
124-
this.eslintStandard.lintText(entry.content).then(results => {
125-
return results.flatMap(result =>
126-
result.messages
127-
.filter(message => message.ruleId !== null) // Ignore messages with null ruleId
128-
.map(message => ({
129-
url: entry.url,
130-
rule: message.ruleId,
131-
category: 'standard',
132-
severity: message.severity === 1 ? "warning" : message.severity === 2 ? "error" : message.severity,
133-
text: message.message,
134-
line: message.line,
135-
column: message.column
136-
}))
137-
);
138-
})
139-
]);
140-
141-
// Wait for all linting promises to resolve and flatten the results
142-
const lintResults = await Promise.all(lintPromises);
143-
knowledgeData.issues = lintResults.flat();
144-
145-
// Populate "resolved-rules" with rules not mentioned in "issues"
146-
// const allRules = [
147-
// ...Object.keys(this.configSecurity[0].rules),
148-
// ...Object.keys(this.configStandard[0].rules)
149-
// ];
150-
// const mentionedRules = new Set(knowledgeData.issues.map(issue => issue.rule));
151-
// knowledgeData['resolved-rules'] = allRules.filter(rule => !mentionedRules.has(rule));
152-
} catch (err) {
153-
// console.error('Error during linting:', err);
154-
}
106+
// Lint with both security and standard configurations
107+
const lintPromises = analyzedData['all-scripts'].flatMap(entry => [
108+
this.eslintSecurity.lintText(entry.content).then(results => {
109+
return results.flatMap(result =>
110+
result.messages
111+
.filter(message => message.ruleId !== null) // Ignore messages with null ruleId
112+
.map(message => ({
113+
url: entry.url,
114+
rule: message.ruleId,
115+
category: 'security',
116+
severity: message.severity === 1 ? "warning" : message.severity === 2 ? "error" : message.severity,
117+
text: message.message,
118+
line: message.line,
119+
column: message.column
120+
}))
121+
);
122+
}),
123+
this.eslintStandard.lintText(entry.content).then(results => {
124+
return results.flatMap(result =>
125+
result.messages
126+
.filter(message => message.ruleId !== null) // Ignore messages with null ruleId
127+
.map(message => ({
128+
url: entry.url,
129+
rule: message.ruleId,
130+
category: 'standard',
131+
severity: message.severity === 1 ? "warning" : message.severity === 2 ? "error" : message.severity,
132+
text: message.message,
133+
line: message.line,
134+
column: message.column
135+
}))
136+
);
137+
})
138+
]);
139+
140+
// Wait for all linting promises to resolve and flatten the results
141+
const lintResults = await Promise.all(lintPromises);
142+
knowledgeData.issues = lintResults.flat();
143+
155144

156145
return knowledgeData;
157146
}

0 commit comments

Comments
 (0)