Skip to content

Conversation

@cbravobernal
Copy link
Contributor

What

Backports from 6.7.0. Do not review yet.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 16.06838% with 491 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.01%. Comparing base (0a774ff) to head (0164138).
⚠️ Report is 20 commits behind head on trunk.

Files with missing lines Patch % Lines
includes/blocks.php 0.00% 112 Missing ⚠️
...sets/src/js/pro/blocks-v3/components/jsx-parser.js 11.76% 105 Missing ⚠️
...sets/src/js/pro/blocks-v3/components/block-edit.js 41.00% 82 Missing ⚠️
...pro/blocks-v3/components/inline-editing-toolbar.js 1.28% 77 Missing ⚠️
...s/pro/blocks-v3/components/block-toolbar-fields.js 20.93% 34 Missing ⚠️
...src/js/pro/blocks-v3/components/popover-wrapper.js 4.16% 23 Missing ⚠️
assets/src/js/pro/_acf-blocks.js 34.61% 17 Missing ⚠️
assets/src/js/_acf-field-google-map.js 0.00% 11 Missing ⚠️
assets/src/js/_acf-field-accordion.js 0.00% 7 Missing ⚠️
assets/src/js/_acf-tinymce.js 0.00% 7 Missing ⚠️
... and 4 more

❌ Your patch check has failed because the patch coverage (16.06%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #281      +/-   ##
============================================
+ Coverage     10.97%   14.01%   +3.04%     
- Complexity     4284     4389     +105     
============================================
  Files           266      291      +25     
  Lines         33139    35801    +2662     
============================================
+ Hits           3636     5018    +1382     
- Misses        29503    30783    +1280     
Flag Coverage Δ
e2e 28.41% <20.39%> (-1.18%) ⬇️
javascript 2.49% <0.00%> (?)
phpunit 10.42% <0.00%> (+4.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobodonnell
Copy link

After this is fully backported to SCF, it seems like it the plugin will be at a really good point to fully diverge from ACF. By that, I mean the baseline namespace should be converted to scf instead of acf. Obviously there would have to be wrapper functions using the old acf namespace so it is easy to switch from ACF Pro to SCF.

With inline editing support for blocks, SCF will be basically feature complete at that point. Any new features that come about would abstractions over new baseline Gutenberg/FSE features, so they can be built from the ground up instead of back ported from whatever the ACF devs comes up with. I don't there are any major features on the ACF roadmap that would justify further backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants