Fix. Should read Detector register in GetDetector #279
+2,357,749
−11,066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SW-BP-REDUNDANCY by oring Status with CloseStatus when Status is XST_SUCCESS and this would avoid returning XST_SUCCESS incase of glitch attack Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com> Acked-by: Kalyani Akula <Kalyani.akula@xilinx.com>
The ZCU111 rfdc selftest example requires extra clock files. These dependencies need to be added to the YAML for SDT flow. Signed-off-by: Conall O'Griofa <conall.ogriofa@amd.com> Acked-by: Kadamathikuttiyil Karthikeyan Pillai, Anish <anish.kadamathikuttiyil-karthikeyan-pillai@amd.com>
MISRA-C Rule 8.5:An external object or function shall be declared once in one and only one file Solution: Removed the redundant declaration of the function Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-by: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
As part of clean up renamed folder vck190 to versal in misc, added debug header file, added debug level macros, enabled only minimal prints by default Signed-off-by: Sharath Kumar Dasari <sharath.kumar.dasari@xilinx.com> Acked-by: Sreedhar Kundella <sreedhar.kundella@amd.com>
Added Null Check code for EmInit Parameters and Error code in xplmi_status.h Signed-off-by: Mohd Saquib Siraj <mohdsaquib.siraj@amd.com>
Fix HIS_COMF(comment frequency) violations of xilmailbox library by adding comments to the code. Signed-off-by: Harini T <harini.t@amd.com> Acked-by: Srinivas Goud <srinivas.goud@amd.com>
With the existing xilfpga library platform agnostic files xilfpga.c and xilfpga.h ifdef checks are not aligned to the user-exported APIs. Ideally, both should be aligned.To align them updates xilfpga.c and xilfpga.h files with proper platform checks. Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com> Acked-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
…as modular Update XQspiPsu_PolledTransfer and XQspiPsu_InterruptHandler functions as modular. Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix code formatting issues with checkpatch tool. It fixes the indentation, formats the code as per coding standards. Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix HIS_COMF(comment frequency) violations of ipipsu driver by adding comments to the code. Signed-off-by: Harini T <harini.t@amd.com> Acked-by: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_directive_4_7_violation: Calling Xil_WaitForEvent without checking return value. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_10_1_violation: The expression of non-boolean essential type is being interpreted as a boolean value for the operator && Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_10_4_violation: Essential type of the left hand operand is not the same as that of the right operand. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_10_6_violation: Assigning composite expression of width 8 to a target of width 32. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_12_1_violation: Missing explicit parentheses on sub-expression Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_14_4_violation: The condition expression does not have an essentially boolean type. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_15_5_violation: return statement is not the final statement in the compound statement that forms the body of the function. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
Fix the below MISRA C vioation. misra_c_2012_rule_8_5_violation: Symbol XSdPs_ConfigTable is declared more than once. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
change the data type of BaseAddress in XSdPs_Config structure from u32 to UINTPTR.APIs using BaseAddress are type casting u32 into UINTPTR hence this change will not affect any functionality. Change the data type of inline APIs which holds the value of BaseAddress and also XSdPs_CfgInitialize API argument EffectiveAddr from u32 to UINTPTR. Changing the BaseAddress from u32 to UINTPTR will help the unit test to run in host without any segmentation fault. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Acked-for-series: Srinivas Goud <srinivas.goud@amd.com>
XPPU configurations before and after DME response operation. Signed-off-by: Venkatesh Korikana <venkatesh.k@xilinx.com> Acked-by: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
Add a check to make sure user cannot overwrite the an already programmed key. Signed-off-by: Kalyani Akula <kalyani.akula@xilinx.com> Acked-by: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
update Embedded SW license file for 2023.1 Signed-off-by: Manikanta Sreeram <msreeram@xilinx.com>
Update Licene file Signed-off-by: Manikanta Sreeram <manikanta.sreeram@amd.com>
update Embedded SW license file for 2023.1 Signed-off-by: Manikanta Sreeram <msreeram@xilinx.com>
Update Licene file Signed-off-by: Manikanta Sreeram <manikanta.sreeram@amd.com>
…w/embeddedsw into xlnx_rel_v2023.2
Removing tapp section from dpdma and dppsu driver as display drivers are not supposed to be put in peripheral tests as these usually need a seprate setup. Signed-off-by: Yash Ladani <yash.ladani@amd.com> Acked-by: Varunkumar Allagadapa <varunkumar.allagadapa@amd.com>
…cess for AIE2 The early write response is by default enabled for npi_nir REG_CNTL register. Due to this, the NPI register writes are acked before the write actually happens. To ensure the NPI write is actually completed, added NPI read request after write. The hardware ensures all previous writes are committed to HW before responding to read request. Signed-off-by: Naman Trivedi Manojbhai <naman.trivedimanojbhai@amd.com> Acked-by: Ronak Jain <ronak.jain@amd.com>
Fixes "video_common: Add support for HF-SCDB in EDID parser" [3c7edff]. Fix compilation warnings in type casting xvidc_cea861_hdmi_hf_sink_capability_data_block structure. Signed-off-by: Rajesh Gugulothu <rajesh.gugulothu@amd.com> Acked-by: Gaddipati, Naveen <naveen.gaddipati@amd.com>
Add support for DP21-10/13.5/20G linkrates. Acked-by: Rajesh Gugulothu <gugulot@amd.com>
Fix the order of the value of UEID extension in the certificate. Signed-off-by: Harsha Harsha <harsha.harsha@amd.com> Acked-for-series: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
Replace XSecure_MemCpy64 with Xil_SMemCpy. XSecure_memCpy64 is a void function and Xil_SMemCpy returns Status. As a result, change the prototype of the functions calling Xil_SMemCpy to return Status. Signed-off-by: Harsha Harsha <harsha.harsha@amd.com> Acked-for-series: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
…tic.c file Added input argument validations for few missing API's in xsecure_elliptic.c file. Signed-off-by: Triveni Modugula <Triveni.Modugula@amd.com> Acked-by: Kalyani Akula <Kalyani.akula@xilinx.com>
Added SDT support for xilskey examples. Signed-off-by: Nandanikhil Gajulapally <nandanikhil.gajulapally@amd.com> Acked-by: VNSL Durga Challa <vnsl.durga.challa@xilinx.com>
Macro definition is reduced for CPPUTEST to decrease unit test duration. Signed-off-by: Jesus De Haro <jesus.de-haro@amd.com>
Updated for license and copyright at xbasic_types.h Signed-off-by: Meena Paleti <meena.paleti@amd.com>
This Patch Updated copyright information Signed-off-by: ANANTHA NAGA VIDHYA LAVANYA <lavanya.ananthanagavidhya@amd.com> Acked-by: Rama devi Veggalam <rama.devi.veggalam@amd.com>
This reverts commit 2a97c68.
Updated for changelog Signed-off-by: Meena Paleti <meena.paleti@amd.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
Fixed coverity warning EXPRESSION_WITH_MAGIC_NUMBERS by replacing magic number with the corresponding macro. Also fixed MISRA-C Rule 10.1 violation : Operands shall not be of an inappropriate essential type Solution: Typecasted according to the required type. Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-for-series: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
MISRA-C Rule 8.13:A pointer should point to a const-qualified type whenever possible. Solution: Added constant qualifier. Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-for-series: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
MISRA-C Rule 10.3: The value of an expression shall not be assigned to an object with a narrower essential type or of a different essential type category MISRA-C Rule 10.4:Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category Solution: Typecasted accordingly. Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-for-series: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
Compilation warnings occured when ecdsa example ran on r5 are being fixed. Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-for-series: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
MISRA-C Rule 12.2: The righthand operand of a shift operator shall lie in the range zero to one less than the width in bits of the essential type of the left hand operand Solution: Properly typecasted according to the requirement Signed-off-by: VSSLakshmiPrasanna.Vutukuri <vsslakshmiprasanna.vutukuri@amd.com> Acked-for-series: Kundanala, Praveen Teja <praveen.teja.kundanala@amd.com>
… of the hardware dependency Xilflash library yaml meta-data has dependency on emc which is optional, This library will work with or without the emc so ideally xilflash yaml Should have optional driver dependency syntax, workaround this issue By pulling the xilflash library by default irrespective of the hardware Dependency. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com> Acked-by: Siva Durga Prasad Paladugu <siva.durga.prasad.paladugu@amd.com>
Embedded SW license update Signed-off-by: Manikanta Sreeram <manikanta.sreeram@amd.com>
… path As OpenAMP demos depend on having app init object and the app object depends on .repo.yaml path, pass this path via command line argument. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Acked-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
…er ESW apps Install generated ELF at top of build directory Pass App name if given to ELF Remove extra cmake-configure step for OpenAMP and Libmetal apps Remove use of extra app cmake toolchain file for apps Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Acked-for-series: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
…al in BSP Enable BSP support for Zynq platform to be built for OpenAMP and Libmetal libraries Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Acked-for-series: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
Do not run extra configure step. Instead simply pass the relevant OpenAMP Lopper information to the lopper run. This also removes the dependency on App object for OpenAMP Demos in the build app step. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Acked-for-series: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
…nAMP Ensure that cleanup for OpenAMP and Libmetal in the BSP is up to parity with other components Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Acked-for-series: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
Currently tools doesn't support enabling XRAM AXILITE interface so remove XRAM_APB_CLK configuration which selects AXILITE PL source. Signed-off-by: Nicole Baze <nicole.baze@xilinx.com> Acked-by: Arun Kannan <arunbala@amd.com>
A lot of people are trying to send pull requests via github but this is not the right channel to use. Linux project is doing review over emails that's why use git@xilinx.com if you want to contribute changes to this repository. Signed-off-by: Siva Addepalli <sivaprasad.addepalli@xilinx.com>
Signed-off-by: Meena Paleti <meena.paleti@amd.com>
In GetDetector function the Generator VSYNC_F1 register with offset 0x8C is read but Detector VSYNC_F1 register with offset 0x40 should be read instead.
saddepal
force-pushed
the
master
branch
2 times, most recently
from
e929ef8 to
51d9eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GetDetector function the Generator VSYNC_F1 register with offset 0x8C is read but Detector VSYNC_F1 register with offset 0x40 should be read instead.