From 1e09ba92dbab3bd74e5f1f8003772d1ac43def9e Mon Sep 17 00:00:00 2001 From: Marius Retegan Date: Wed, 22 Jan 2025 08:49:33 +0100 Subject: [PATCH 1/3] Make the calculated attribute optional --- src/pynxxas/models/nexus.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pynxxas/models/nexus.py b/src/pynxxas/models/nexus.py index 049f227..07acc50 100644 --- a/src/pynxxas/models/nexus.py +++ b/src/pynxxas/models/nexus.py @@ -103,7 +103,7 @@ class NxXasModel(NxClass, NxGroup, nx_class="NxXas"): mode: NxXasMode element: NxElement edge: NxEdge - calculated: bool = False + calculated: Optional[bool] = False energy: units.PydanticQuantity = units.as_quantity([]) intensity: units.PydanticQuantity = units.as_quantity([]) title: Optional[str] = None From 3db86230cf1c7b67b1537a6959baff933d784287 Mon Sep 17 00:00:00 2001 From: Marius Retegan Date: Wed, 22 Jan 2025 09:04:10 +0100 Subject: [PATCH 2/3] Default to None --- src/pynxxas/models/nexus.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pynxxas/models/nexus.py b/src/pynxxas/models/nexus.py index 07acc50..4ac29ab 100644 --- a/src/pynxxas/models/nexus.py +++ b/src/pynxxas/models/nexus.py @@ -103,7 +103,7 @@ class NxXasModel(NxClass, NxGroup, nx_class="NxXas"): mode: NxXasMode element: NxElement edge: NxEdge - calculated: Optional[bool] = False + calculated: Optional[bool] = None energy: units.PydanticQuantity = units.as_quantity([]) intensity: units.PydanticQuantity = units.as_quantity([]) title: Optional[str] = None From 5d143d28bd55f32ddc2c316dce119e3a676bea45 Mon Sep 17 00:00:00 2001 From: Marius Retegan Date: Wed, 22 Jan 2025 09:12:38 +0100 Subject: [PATCH 3/3] Fix tests --- src/pynxxas/tests/test_nexus.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pynxxas/tests/test_nexus.py b/src/pynxxas/tests/test_nexus.py index 3af4cca..c504510 100644 --- a/src/pynxxas/tests/test_nexus.py +++ b/src/pynxxas/tests/test_nexus.py @@ -83,7 +83,7 @@ def _expected_content(nx_class, energy, intensity): "intensity": intensity, "title": "Fe K (transmission)", "instrument": None, - "calculated": False, + "calculated": None, "plot": { "NX_class": "NXdata", "axes": [