-
Notifications
You must be signed in to change notification settings - Fork 60
Description
Currently using node-id3 for a project and it's working very well. However, some of my external dependencies expect the ID3 data to be ISO_8859_1 encoded rather than the default UTF_16_WITH_BOM. So, I've had to make a change on line 12 of src/frames/generic.ts to change the encoding.
Allowing users to specify the text encoding when writing ID3 tags would be a great added feature. Specifically, it would be great if users could choose from the encodings in src/definitions/Encoding.ts.
I'd be happy to write a PR for adding this functionality, but I'm not sure what the cleanest way would be. Hoping for some guidance from the project authors. Any thoughts on the best way for a user to specify encoding? Maybe an argument to write or as another field in the tags object?