Support encoding GEOB frames with latin1

[laker-93]

The comment here suggests GEOB frames are encoded as latin1: https://github.com/Zazama/node-id3/blob/0.2/index.d.ts#L545
which I believe is the standard.

However, the code actually hard codes the encoding to UTF-16 here: https://github.com/Zazama/node-id3/blob/0.2/src/ID3Frames.js#L565
This means any GEOB frames written with this library are often invalid and can't be read by other programs.

Can the encoding be switched to use latin1 instead? Or alternatively support a way to pass in the encoding?

[laker-93]

I've created a PR to fix here: #188

[Zazama]

Hello laker-93, thanks for your PR. We can't change the default encoding like that because it would break text that otherwise is correct, as latin-1 is not going to be able to represent all characters.

However, this might not be the issue anyways.

node-id3/src/ID3Frames.js

Line 569 in a266c0e

.appendNullTerminatedValue(geob.mimeType ? geob.mimeType : '')

There actually is a problem here, because the mime type should always be latin-1 encoded. Do you mind changing the default encoding back to 0x01 and changing only this line to

.appendNullTerminatedValue(geob.mimeType ? geob.mimeType : '', 0x00)

and see if it fixes your problems?

[laker-93]

I think I need the encoding of the other fields to be configurable. If I set encoding to latin1 here using this library, then the tags can be read by my program.

https://github.com/eidoriantan/mp3tag.js/blob/main/src/id3v2/write.mjs#L227C15-L227C64

Either way, I've made the change you've requested so feel free to merge if helpful.