From 84e9cdfefe385bace6f3a9acbe4019bae8162763 Mon Sep 17 00:00:00 2001 From: "Eric k." <81742990+ledemkam@users.noreply.github.com> Date: Sun, 31 Aug 2025 14:44:40 +0200 Subject: [PATCH] modified --- pom.xml | 2 ++ .../testing/calcul/service/CalculatorServiceImpl.java | 2 ++ .../testing/calcul/service/SolutionFormatterImpl.java | 2 +- .../calcul/e2e/MultiplicationJourneyE2ETest.java | 10 +++++----- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/pom.xml b/pom.xml index 6aa21e1..8d4545a 100644 --- a/pom.xml +++ b/pom.xml @@ -72,6 +72,7 @@ javax.inject 1 + org.seleniumhq.selenium selenium-java @@ -82,6 +83,7 @@ webdrivermanager 3.7.1 + calculator diff --git a/src/main/java/tech/zerofiltre/testing/calcul/service/CalculatorServiceImpl.java b/src/main/java/tech/zerofiltre/testing/calcul/service/CalculatorServiceImpl.java index 77ef1fd..5b12675 100644 --- a/src/main/java/tech/zerofiltre/testing/calcul/service/CalculatorServiceImpl.java +++ b/src/main/java/tech/zerofiltre/testing/calcul/service/CalculatorServiceImpl.java @@ -2,11 +2,13 @@ import javax.inject.Named; + import tech.zerofiltre.testing.calcul.domain.Calculator; import tech.zerofiltre.testing.calcul.domain.model.CalculationModel; import tech.zerofiltre.testing.calcul.domain.model.CalculationType; @Named + public class CalculatorServiceImpl implements CalculatorService { private final Calculator calculator; diff --git a/src/main/java/tech/zerofiltre/testing/calcul/service/SolutionFormatterImpl.java b/src/main/java/tech/zerofiltre/testing/calcul/service/SolutionFormatterImpl.java index 99a0f21..0eb9d1b 100644 --- a/src/main/java/tech/zerofiltre/testing/calcul/service/SolutionFormatterImpl.java +++ b/src/main/java/tech/zerofiltre/testing/calcul/service/SolutionFormatterImpl.java @@ -9,6 +9,6 @@ public class SolutionFormatterImpl implements SolutionFormatter { @Override public String format(int solution) { - return String.format(Locale.FRENCH, "%,d", solution); + return String.format(Locale.GERMAN, "%,d", solution); } } diff --git a/src/test/java/tech/zerofiltre/testing/calcul/e2e/MultiplicationJourneyE2ETest.java b/src/test/java/tech/zerofiltre/testing/calcul/e2e/MultiplicationJourneyE2ETest.java index aff1351..bea3b79 100644 --- a/src/test/java/tech/zerofiltre/testing/calcul/e2e/MultiplicationJourneyE2ETest.java +++ b/src/test/java/tech/zerofiltre/testing/calcul/e2e/MultiplicationJourneyE2ETest.java @@ -10,7 +10,7 @@ import org.openqa.selenium.By; import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; -import org.openqa.selenium.chrome.ChromeDriver; + import org.openqa.selenium.firefox.FirefoxDriver; import org.openqa.selenium.support.ui.ExpectedConditions; import org.openqa.selenium.support.ui.WebDriverWait; @@ -19,7 +19,7 @@ import org.springframework.boot.web.server.LocalServerPort; @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT) -public class MultiplicationJourneyE2ETest { +class MultiplicationJourneyE2E { @LocalServerPort private int port; @@ -47,7 +47,7 @@ void quitWebDriver() { } @Test - void multiplyTwoBySixteenMustReturn32(){ + void multiplyTwoBySixteenMustReturn32() { //GIVEN webDriver.get(baseUrl); @@ -63,11 +63,11 @@ void multiplyTwoBySixteenMustReturn32(){ submitButton.click(); //THEN - WebDriverWait waiter = new WebDriverWait(webDriver,5); + WebDriverWait waiter = new WebDriverWait(webDriver, 5); WebElement solutionElement = waiter.until(ExpectedConditions.presenceOfElementLocated(By.id("solution"))); String solution = solutionElement.getText(); assertThat(solution).isEqualTo("32"); } -} +} \ No newline at end of file