From 231f7e05a13ccc59d305c69ca514af7aba07a68a Mon Sep 17 00:00:00 2001 From: "ansible-code-bot[bot]" <146274539+ansible-code-bot[bot]@users.noreply.github.com> Date: Mon, 22 Jan 2024 18:44:28 +0000 Subject: [PATCH] Fix ansible-lint rule violations --- .../geerlingguy/php_roles/galaxy-deploy.yml | 2 +- demo.yml | 27 +++++++++---------- .../defaults/main.yml | 4 +-- roles/geerlingguy.elasticsearch/meta/main.yml | 5 ++-- .../geerlingguy.elasticsearch/tasks/main.yml | 5 ++-- .../tasks/setup-Debian.yml | 2 +- .../tasks/setup-RedHat.yml | 2 +- 7 files changed, 22 insertions(+), 25 deletions(-) diff --git a/collections/ansible_collections/geerlingguy/php_roles/galaxy-deploy.yml b/collections/ansible_collections/geerlingguy/php_roles/galaxy-deploy.yml index 3c40c8f..eb9ec2e 100644 --- a/collections/ansible_collections/geerlingguy/php_roles/galaxy-deploy.yml +++ b/collections/ansible_collections/geerlingguy/php_roles/galaxy-deploy.yml @@ -24,7 +24,7 @@ - name: Ensure ANSIBLE_GALAXY_TOKEN is set. fail: msg: A valid ANSIBLE_GALAXY_TOKEN must be set. - when: "lookup('env','ANSIBLE_GALAXY_TOKEN') | length == 0" + when: lookup('env','ANSIBLE_GALAXY_TOKEN') | length == 0 - name: Ensure the ~/.ansible directory exists. file: diff --git a/demo.yml b/demo.yml index 61ebfc9..d9ff7d1 100644 --- a/demo.yml +++ b/demo.yml @@ -1,5 +1,5 @@ --- -- name: Demo Lightspeed extension +- name: Demo Lightspeed extension hosts: localhost vars: firewall_pkg: firewalld @@ -7,7 +7,7 @@ ssl_pkg: mod_ssl secret_src: /home/abeisemb/Pictures/thinking.png secret_dest: /home/abeisemb/Pictures/thonking.png - tasks: + tasks: - name: Task block block: - name: Install web_pkg on our local system @@ -16,12 +16,12 @@ state: present delegate_to: localhost when: true - + - name: Set up ssl_pkg. ansible.builtin.set_fact: ssl_cmd: sudo -u apache apache2ctl configtest when: ssl_cmd is not defined - + - name: Repeat the above task. ansible.builtin.debug: msg: "{{ ssl_cmd }}" @@ -29,30 +29,30 @@ - name: Print all relevant facts. ansible.builtin.debug: var: ansible_facts - + - name: File my taxes. ansible.builtin.stat: path: /tmp/ansible_facts.txt register: stat_result - + - name: Create a task that notifies the spaghetti handler. ansible.builtin.copy: dest: /tmp/ansible_facts.txt content: " hi from inside the new file\n" when: not stat_result.stat.exists - + - name: Copy secret_src to secret_dest with mode 0777. ansible.builtin.copy: src: "{{ secret_src }}" dest: "{{ secret_dest }}" - mode: '0777' + mode: "0777" - name: Configure SELinux to permissive mode. ansible.posix.selinux: policy: targeted state: permissive when: ansible_facts['os_family'] == "RedHat" - + - name: Set the tuned-adm profile to desktop. community.general.alternatives: name: tuned-adm @@ -65,7 +65,7 @@ state: enforcing when: ansible_facts['os_family'] == "RedHat" - # Install postgresql-server & run postgresql-setup command. + # Install postgresql-server & run postgresql-setup command. - name: Install postgresql-server ansible.builtin.package: name: "{{ _name_ }}" @@ -76,8 +76,7 @@ ansible.builtin.command: postgresql-setup initdb ignore_errors: true - - name: Pull from a theoretical git repo. - git: - repo: "https://github.com/abeisemb/lightspeed-code-bot-test-abeisemb" + - name: Pull from a theoretical git repo. + git: + repo: https://github.com/abeisemb/lightspeed-code-bot-test-abeisemb version: HEAD - diff --git a/roles/geerlingguy.elasticsearch/defaults/main.yml b/roles/geerlingguy.elasticsearch/defaults/main.yml index 132a301..48baab6 100644 --- a/roles/geerlingguy.elasticsearch/defaults/main.yml +++ b/roles/geerlingguy.elasticsearch/defaults/main.yml @@ -1,5 +1,5 @@ --- -elasticsearch_version: '7.x' +elasticsearch_version: 7.x elasticsearch_package: elasticsearch elasticsearch_package_state: present @@ -12,4 +12,4 @@ elasticsearch_http_port: 9200 elasticsearch_heap_size_min: 1g elasticsearch_heap_size_max: 2g -elasticsearch_extra_options: '' +elasticsearch_extra_options: "" diff --git a/roles/geerlingguy.elasticsearch/meta/main.yml b/roles/geerlingguy.elasticsearch/meta/main.yml index 013d349..c006854 100644 --- a/roles/geerlingguy.elasticsearch/meta/main.yml +++ b/roles/geerlingguy.elasticsearch/meta/main.yml @@ -1,12 +1,11 @@ --- dependencies: [] - galaxy_info: role_name: elasticsearch author: geerlingguy description: Elasticsearch for Linux. - company: "Midwestern Mac, LLC" - license: "license (BSD, MIT)" + company: Midwestern Mac, LLC + license: license (BSD, MIT) min_ansible_version: 2.4 platforms: - name: EL diff --git a/roles/geerlingguy.elasticsearch/tasks/main.yml b/roles/geerlingguy.elasticsearch/tasks/main.yml index 1926fe7..399eff7 100644 --- a/roles/geerlingguy.elasticsearch/tasks/main.yml +++ b/roles/geerlingguy.elasticsearch/tasks/main.yml @@ -1,5 +1,4 @@ --- - - include_tasks: setup-RedHat.yml when: ansible_os_family == 'RedHat' @@ -17,7 +16,7 @@ dest: "{{ item }}" owner: root group: elasticsearch - mode: 0660 + mode: "0660" with_items: - /etc/elasticsearch/elasticsearch.yml - /etc/elasticsearch/jvm.options @@ -30,7 +29,7 @@ dest: "{{ item }}" owner: root group: elasticsearch - mode: 0660 + mode: "0660" with_items: - /etc/elasticsearch/elasticsearch.yml - /etc/elasticsearch/jvm.options.d/heap.options diff --git a/roles/geerlingguy.elasticsearch/tasks/setup-Debian.yml b/roles/geerlingguy.elasticsearch/tasks/setup-Debian.yml index 9fde3c9..9dcccc5 100644 --- a/roles/geerlingguy.elasticsearch/tasks/setup-Debian.yml +++ b/roles/geerlingguy.elasticsearch/tasks/setup-Debian.yml @@ -13,6 +13,6 @@ - name: Add Elasticsearch repository. apt_repository: - repo: 'deb https://artifacts.elastic.co/packages/{{ elasticsearch_version }}/apt stable main' + repo: deb https://artifacts.elastic.co/packages/{{ elasticsearch_version }}/apt stable main state: present update_cache: true diff --git a/roles/geerlingguy.elasticsearch/tasks/setup-RedHat.yml b/roles/geerlingguy.elasticsearch/tasks/setup-RedHat.yml index 3882cd2..fdb3e78 100644 --- a/roles/geerlingguy.elasticsearch/tasks/setup-RedHat.yml +++ b/roles/geerlingguy.elasticsearch/tasks/setup-RedHat.yml @@ -8,4 +8,4 @@ template: src: elasticsearch.repo.j2 dest: /etc/yum.repos.d/elasticsearch.repo - mode: 0644 + mode: "0644"