Skip to content

Do not cast column to string #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WilliamDEdwards wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not cast column to string #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/crud/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from fastapi.encoders import jsonable_encoder
from more_itertools import one
from sqlalchemy import String, cast, or_
from sqlalchemy import or_
from sqlalchemy.inspection import inspect as sa_inspect
from sqlalchemy.sql import expression

Expand Down Expand Up @@ -59,13 +59,13 @@ def get_multi(
# treat the key as the value
if len(value) > 0:
if key in sa_inspect(self.model).columns.keys():
conditions.append(cast(self.model.__dict__[key], String).ilike("%" + one(value) + "%"))
conditions.append(self.model.__dict__[key].ilike("%" + one(value) + "%"))
else:
logger.info(f"Key: not found in database model key={key}, model={self.model}")
query = query.filter(or_(*conditions))
else:
for column in sa_inspect(self.model).columns.keys():
conditions.append(cast(self.model.__dict__[column], String).ilike("%" + key + "%"))
conditions.append(self.model.__dict__[column].ilike("%" + key + "%"))
query = query.filter(or_(*conditions))

if sort_parameters and len(sort_parameters):
Expand Down