improve(SpokePool): deposit with message gas optimization (#603)

nicholaspai · web-flow · commit 6c9d5b6095fe · 2024-09-12T17:14:05.000+02:00
In most cases, we can avoid having to do the `extcodesize` call that’s inside `isContract()`. This could save [~2600](https://github.com/wolflo/evm-opcodes/blob/main/gas.md#a5-balance-extcodesize-extcodehash) gas per call for non ETH bridges to EOAs
diff --git a/contracts/SpokePool.sol b/contracts/SpokePool.sol
@@ -1372,7 +1372,7 @@ abstract contract SpokePool is
         }
 
         bytes memory updatedMessage = relayExecution.updatedMessage;
-        if (recipientToSend.isContract() && updatedMessage.length > 0) {
+        if (updatedMessage.length > 0 && recipientToSend.isContract()) {
             AcrossMessageHandler(recipientToSend).handleV3AcrossMessage(
                 outputToken,
                 amountToSend,

Original file line number	Diff line number	Diff line change
`@@ -1372,7 +1372,7 @@ abstract contract SpokePool is`
`1372`	`1372`	`}`
`1373`	`1373`
`1374`	`1374`	`bytes memory updatedMessage = relayExecution.updatedMessage;`
`1375`		`- if (recipientToSend.isContract() && updatedMessage.length > 0) {`
	`1375`	`+ if (updatedMessage.length > 0 && recipientToSend.isContract()) {`
`1376`	`1376`	`AcrossMessageHandler(recipientToSend).handleV3AcrossMessage(`
`1377`	`1377`	`outputToken,`
`1378`	`1378`	`amountToSend,`