improve(BundleDataClient): Don't create slow fill leaves for invalid recipients (#855)

nicholaspai · web-flow · commit adb07ac0e9d5 · 2025-01-31T17:16:11.000-05:00
diff --git a/src/clients/BundleDataClient/BundleDataClient.ts b/src/clients/BundleDataClient/BundleDataClient.ts
@@ -139,6 +139,9 @@ function updateBundleExcessSlowFills(
 }
 
 function updateBundleSlowFills(dict: BundleSlowFills, deposit: V3DepositWithBlock & { lpFeePct: BigNumber }): void {
+  if (chainIsEvm(deposit.destinationChainId) && !isValidEvmAddress(deposit.recipient)) {
+    return;
+  }
   const { destinationChainId, outputToken } = deposit;
   if (!dict?.[destinationChainId]?.[outputToken]) {
     assign(dict, [destinationChainId, outputToken], []);

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,9 @@ function updateBundleExcessSlowFills(`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`function updateBundleSlowFills(dict: BundleSlowFills, deposit: V3DepositWithBlock & { lpFeePct: BigNumber }): void {`
	`142`	`+ if (chainIsEvm(deposit.destinationChainId) && !isValidEvmAddress(deposit.recipient)) {`
	`143`	`+ return;`
	`144`	`+ }`
`142`	`145`	`const { destinationChainId, outputToken } = deposit;`
`143`	`146`	`if (!dict?.[destinationChainId]?.[outputToken]) {`
`144`	`147`	`assign(dict, [destinationChainId, outputToken], []);`