Annotations not set correctly

[justas200]

Checks

• I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
• I am using charts that are officially provided

Controller Version

0.12.1

Deployment Method

Helm

Checks

• This isn't a question or user support case (For Q&A and community support, go to Discussions).
• I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Set gha-runner-scale-set annotations.
2. Annotations are not added to AutoscalingListener, listener role and listener role-binding.

Describe the bug

However if I use default labels they are added to all the resources.
There is no easy way to track these resources using ArgoCD.

Describe the expected behavior

I wish the annotations were added to all the resources exactly the same as labels are.

Additional Context

annotations:
  argocd.argoproj.io/tracking-id: "github-runners-gha-runner-scale-set"
labels:
  argocd.argoproj.io/tracking-id: "github-runners-gha-runner-scale-set"
resourceMeta:
  autoscalingRunnerSet:
    annotations:
      argocd.argoproj.io/tracking-id: "github-runners-gha-runner-scale-set"

Controller Logs

There are no useful logs.

Runner Pod Logs

There are no useful logs.

[aladdin-nawasrah]

Any update here?

[aladdin-nawasrah]

We need to be able to annotate the runner and the workflow pods to avoid eviction, so I think this issue is highly important.

[nikola-jokic]

I don't think there is anything stopping you since the runner pod spec is controlled by you, but please correct me if I'm wrong.

[Coconutcoo]

We're also struggling with this, our ARC deployment is managed by terraform and helm, for the moment I've had to just add a separate step after the runner chart is deployed to annotate the listener manually for datadog metric ingestion.

This should be as easy as annotating the runner itself (which uses the podAnnotations value correctly), and labels for the listeners seem to work fine, so it's just an issue with annotations and listener pods specifically.

[tysoncung]

Thanks for opening this issue! I'm interested in contributing to this. 👋

🤔 Understanding the Requirements

To provide the best solution, I'd like to understand:

Context:

• What's the current behavior?
• What's the expected/desired behavior?
• What's the impact or use case?

Scope:

• Are there any specific requirements or constraints?
• Any preferences for implementation approach?
• Related issues or PRs?

Success Criteria:

• What would "done" look like for this issue?
• Any specific metrics or tests needed?

💪 How I Can Help

I have experience with actions projects and can contribute:

• 🔍 Investigation: Research and propose solutions
• 💻 Implementation: Write clean, tested code
• ✅ Testing: Comprehensive test coverage
• 📚 Documentation: Clear docs and examples
• 👀 Review: Iterate based on feedback

🚀 My Approach

1. Understand requirements thoroughly
2. Research best practices and similar solutions
3. Design before implementing
4. Write tests first (TDD)
5. Implement incrementally
6. Document clearly
7. Iterate based on review

Let me know if this is still open and how I can help! I'm excited to contribute. 🎯

My relevant experience:

• Similar projects and features
• Modern development practices
• Open source contribution
• Production system experience

Feel free to assign this to me if you'd like me to work on it! 🙌