Merge pull request #175 from lesamouraipourpre/u2if

Move the U2IF constant definitions to a single file so they are not duplicated

Author: makermelissa

.pylintrc

@@ -18,8 +18,7 @@ ignore-patterns=
 #init-hook=
 
 # Use multiple processes to speed up Pylint.
-# jobs=1
-jobs=2
+jobs=1
 
 # List of plugins (as comma separated values of python modules names) to load,
 # usually to register additional checkers.
@@ -249,7 +248,7 @@ ignore-docstrings=yes
 ignore-imports=no
 
 # Minimum lines number of a similarity.
-min-similarity-lines=4
+min-similarity-lines=12
 
 
 [BASIC]

adafruit_platformdetect/board.py

@@ -157,16 +157,8 @@ def id(self):
             board_id = self._stm32mp1_id()
         elif chip_id == chips.MT8167:
             board_id = boards.CORAL_EDGE_TPU_DEV_MINI
-        elif chip_id == chips.PICO_U2IF:
-            board_id = boards.PICO_U2IF
-        elif chip_id == chips.FEATHER_U2IF:
-            board_id = boards.FEATHER_U2IF
-        elif chip_id == chips.ITSYBITSY_U2IF:
-            board_id = boards.ITSYBITSY_U2IF
-        elif chip_id == chips.QTPY_U2IF:
-            board_id = boards.QTPY_U2IF
-        elif chip_id == chips.QT2040_TRINKEY_U2IF:
-            board_id = boards.QT2040_TRINKEY_U2IF
+        elif chip_id == chips.RP2040_U2IF:
+            board_id = self._rp2040_u2if_id()
         elif chip_id == chips.GENERIC_X86:
             board_id = boards.GENERIC_LINUX_PC
         self._board_id = board_id
@@ -468,6 +460,32 @@ def _allwinner_variants_id(self):
             # TODO: Add other specifc board contexts here
         return board
 
+    def _rp2040_u2if_id(self):
+        import hid
+
+        # look for it based on PID/VID
+        for dev in hid.enumerate():
+            # Raspberry Pi Pico
+            vendor = dev["vendor_id"]
+            product = dev["product_id"]
+            if vendor == 0xCAFE and product == 0x4005:
+                return boards.PICO_U2IF
+            if vendor == 0x239A:
+                # Feather RP2040
+                if product == 0x00F1:
+                    return boards.FEATHER_U2IF
+                # Itsy Bitsy RP2040
+                if product == 0x00FD:
+                    return boards.ITSYBITSY_U2IF
+                # QT Py RP2040
+                if product == 0x00F7:
+                    return boards.QTPY_U2IF
+                # QT2040 Trinkey
+                if product == 0x0109:
+                    return boards.QT2040_TRINKEY_U2IF
+        # Will only reach here if a device was added in chip.py but here.
+        raise RuntimeError("RP2040_U2IF device was added to chip but not board.")
+
     @property
     def any_nanopi(self):
         """Check whether the current board is any defined Nano Pi."""

adafruit_platformdetect/chip.py

@@ -113,25 +113,23 @@ def id(
 
                 # look for it based on PID/VID
                 for dev in hid.enumerate():
-                    # Raspberry Pi Pico
-                    if dev["vendor_id"] == 0xCAFE and dev["product_id"] == 0x4005:
-                        self._chip_id = chips.PICO_U2IF
-                        return self._chip_id
-                    # Feather RP2040
-                    if dev["vendor_id"] == 0x239A and dev["product_id"] == 0x00F1:
-                        self._chip_id = chips.FEATHER_U2IF
-                        return self._chip_id
-                    # Itsy Bitsy RP2040
-                    if dev["vendor_id"] == 0x239A and dev["product_id"] == 0x00FD:
-                        self._chip_id = chips.ITSYBITSY_U2IF
-                        return self._chip_id
-                    # QT Py RP2040
-                    if dev["vendor_id"] == 0x239A and dev["product_id"] == 0x00F7:
-                        self._chip_id = chips.QTPY_U2IF
-                        return self._chip_id
-                    # QT2040 Trinkey
-                    if dev["vendor_id"] == 0x239A and dev["product_id"] == 0x0109:
-                        self._chip_id = chips.QT2040_TRINKEY_U2IF
+                    vendor = dev["vendor_id"]
+                    product = dev["product_id"]
+                    # NOTE: If any products are added here, they need added
+                    # to _rp2040_u2if_id() in board.py as well.
+                    if (
+                        # Raspberry Pi Pico
+                        vendor == 0xCAFE
+                        and product == 0x4005
+                    ) or (
+                        # Feather RP2040
+                        # Itsy Bitsy RP2040
+                        # QT Py RP2040
+                        # QT2040 Trinkey
+                        vendor == 0x239A
+                        and product in (0x00F1, 0x00FD, 0x00F7, 0x0109)
+                    ):
+                        self._chip_id = chips.RP2040_U2IF
                         return self._chip_id
                 raise RuntimeError(
                     "BLINKA_U2IF environment variable "

adafruit_platformdetect/constants/chips.py

@@ -46,11 +46,7 @@
 STM32MP157 = "STM32MP157"
 MT8167 = "MT8167"
 ATOM_X5_Z8350 = "X5-Z8350"
-PICO_U2IF = "PICO_U2IF"
-FEATHER_U2IF = "FEATHER_U2IF"
-ITSYBITSY_U2IF = "ITSYBITSY_U2IF"
-QTPY_U2IF = "QTPY_U2IF"
-QT2040_TRINKEY_U2IF = "QT2040_TRINKEY_U2IF"
+RP2040_U2IF = "RP2040_U2IF"
 
 
 BCM_RANGE = {"BCM2708", "BCM2709", "BCM2711", "BCM2835", "BCM2837"}