feat: integrate AdCP schema improvements (PR #222 + #223) (#73)

* feat: resolve schema collisions with AssetContentType, FormatCategory, and unified Package

Implements changes from upstream AdCP PR #222 and PR #223:

**New Types (PR #222)**
- AssetContentType: Consolidated enum for asset content types (13 values)
- FormatCategory: Semantic enum for format categories (7 values)

**Unified Package (PR #223)**
- create_media_buy and update_media_buy now return full Package objects
- Removed CreatedPackageReference (deprecated)
- Better API consistency and developer experience

**Breaking Changes**
- Removed CreatedPackageReference: use Package directly
- Removed AffectedPackage: removed from upstream schemas

**Backward Compatibility**
- AssetType maintained as deprecated alias to AssetContentType

Test results: 283/295 passing (12 failures for removed CreatedPackageReference - expected)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test: remove obsolete CreatedPackageReference tests

Removed 5 test functions that tested CreatedPackageReference since this type
was removed in AdCP PR #223. The PR unified Package responses so that both
create_media_buy and update_media_buy now return full Package objects instead
of minimal references.

Removed tests:
- test_package_type_aliases_imports
- test_package_type_aliases_point_to_correct_modules
- test_package_type_aliases_have_correct_fields
- test_package_type_aliases_in_exports
- test_package_aliases_can_instantiate

All 290 tests now pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: consolidate schema analysis into changelog, remove temp docs

Removed temporary documentation files (SCHEMA_COLLISION_PROPOSAL.md,
UPSTREAM_SCHEMA_RECOMMENDATIONS.md) that were used during analysis.

Enhanced CHANGELOG_ENTRY.md to include:
- Detailed description of upstream schema improvements (PR #222 + #223)
- Complete list of new types with all enum values
- Expanded migration guide with more examples
- Upstream recommendations identified during integration

The key findings (orphaned asset-type.json, enum organization suggestions,
discriminator standardization opportunities) are now captured in the changelog
for future reference.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: remove orphaned asset-type.json and update schemas

Upstream PR #222 removed the orphaned asset-type.json schema file. Our local
cache had stale copies that were no longer referenced upstream.

Changes:
- Removed stale asset-type.json from schemas/cache/1.0.0/
- Removed asset_type.py generated file (no longer has upstream schema)
- Removed orphaned type exports: AssetTypeSchema, ContentLength, Dimensions,
  Duration, FileSize, Quality, Requirements
- Added deprecation alias: AssetType = AssetContentType
- Synced 6 updated schemas (deployment, destination, activate-signal, get-signals)

The sync discovered asset-type.json was 404 upstream - it was removed in PR #222
as part of the enum consolidation work.

Tests: 288/290 passing (2 failures in signals tests due to schema API changes
from destinations → deployments in upstream)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: update changelog to reflect upstream already removed asset-type.json

The orphaned asset-type.json was already removed by the AdCP team in PR #222.
Updated changelog to acknowledge this was properly handled upstream.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: automatically remove orphaned schemas during sync

Added automatic cleanup of schema files that no longer exist upstream.
This prevents stale cached schemas from causing issues when upstream
removes or renames schema files.

Changes:
- Scan for JSON files in cache that aren't in the upstream schema list
- Remove orphaned files and their empty parent directories
- Report removed count in sync summary
- Updated script documentation to explain new feature

Example output:
  Cleaning up orphaned schemas:
    ✗ asset-type.json (removed - no longer in upstream)
    ✗ core/asset-type.json (removed - no longer in upstream)

This would have automatically caught the stale asset-type.json files
that were orphaned after PR #222.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: update signals API tests for destinations → deployments change

Upstream schema updates changed the signals API from using 'destinations'
to 'deployments'. Updated test fixtures to match new API structure.

Changes:
- GetSignalsRequest.deliver_to.destinations → deployments
- ActivateSignalRequest.destinations → deployments

Tests now passing: 290/290 (100%)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: remove temporary changelog entry file

Release Please will automatically generate changelog from commits.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: resolve linter errors in stable.py and __init__.py

- Fix import sorting per ruff I001 rules
- Fix line length by moving comment above import
- Remove orphaned 'Requirements' from __all__ (type was removed with asset-type.json)

All linter checks now passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: bokelley

schemas/cache/1.0.0/asset-type.json

@@ -6,6 +6,12 @@
 not just those listed in index.json. This ensures we get all schemas including
 asset types (vast-asset.json, daast-asset.json) with discriminators from PR #189.
 
+Features:
+- Content-based change detection (only updates files when content changes)
+- Automatic cleanup of orphaned schemas (files removed upstream)
+- Preserves directory structure from upstream
+- Symlink to latest version for convenience
+
 Usage:
     python scripts/sync_schemas.py          # Normal sync (uses content hashing)
     python scripts/sync_schemas.py --force  # Force re-download all schemas
@@ -207,6 +213,7 @@ def main():
         print("Downloading schemas:")
         updated_count = 0
         cached_count = 0
+        removed_count = 0
 
         for url in schema_urls:
             was_updated, new_hash = download_schema_file(url, version, hash_cache, force=args.force)
@@ -219,6 +226,37 @@ def main():
             if new_hash:
                 updated_hashes[url] = new_hash
 
+        # Clean up orphaned schemas (files that exist locally but not upstream)
+        version_dir = CACHE_DIR / version
+        if version_dir.exists():
+            # Get list of expected filenames from URLs
+            expected_files = {url.split("/")[-1] for url in schema_urls}
+            # Also allow the hash cache file
+            expected_files.add(".hashes.json")
+
+            # Find orphaned JSON files
+            orphaned_files = []
+            for json_file in version_dir.rglob("*.json"):
+                if json_file.name not in expected_files and json_file.name != ".hashes.json":
+                    orphaned_files.append(json_file)
+
+            # Remove orphaned files
+            if orphaned_files:
+                print("\nCleaning up orphaned schemas:")
+                for orphan in orphaned_files:
+                    rel_path = orphan.relative_to(version_dir)
+                    print(f"  ✗ {rel_path} (removed - no longer in upstream)")
+                    orphan.unlink()
+                    removed_count += 1
+
+                    # Remove empty directories
+                    parent = orphan.parent
+                    try:
+                        if parent != version_dir and not any(parent.iterdir()):
+                            parent.rmdir()
+                    except OSError:
+                        pass
+
         # Save updated hash cache
         if updated_hashes:
             save_hash_cache(updated_hashes)
@@ -237,6 +275,8 @@ def main():
         print(f"  Location: {version_dir}")
         print(f"  Updated: {updated_count}")
         print(f"  Cached: {cached_count}")
+        if removed_count > 0:
+            print(f"  Removed: {removed_count} (orphaned)")
 
     except Exception as e:
         print(f"\n✗ Error syncing schemas: {e}", file=sys.stderr)

schemas/cache/1.0.0/core/asset-type.json

@@ -108,6 +108,8 @@
     # Audience & Targeting
     ActivateSignalRequest,
     ActivateSignalResponse,
+    # Type enums from PR #222
+    AssetContentType,
     # Core domain types
     BrandManifest,
     # Creative Operations
@@ -131,6 +133,7 @@
     Error,
     FlatRatePricingOption,
     Format,
+    FormatCategory,
     FormatId,
     GetMediaBuyDeliveryRequest,
     GetMediaBuyDeliveryResponse,
@@ -218,6 +221,9 @@
     "Error",
     "Format",
     "FormatId",
+    # New type enums from PR #222
+    "AssetContentType",
+    "FormatCategory",
     "Product",
     "Property",
     # Core domain types (from stable API)