Skip to content

Commit e1664aa

Browse files
committed
fix: tests
1 parent aabb322 commit e1664aa

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/adcp/utils/preview_cache.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,15 @@ async def get_preview_data_for_manifest(
8787
first_render = preview.renders[0] if preview.renders else None
8888

8989
if first_render:
90-
has_url = hasattr(first_render, "preview_url")
91-
preview_url = str(first_render.preview_url) if has_url else None
90+
# PreviewRender is a RootModel, access attributes via .root
91+
render = first_render.root
92+
has_url = hasattr(render, "preview_url")
93+
preview_url = str(render.preview_url) if has_url else None
9294
preview_data = {
9395
"preview_id": preview.preview_id,
9496
"preview_url": preview_url,
95-
"preview_html": getattr(first_render, "preview_html", None),
96-
"render_id": first_render.render_id,
97+
"preview_html": getattr(render, "preview_html", None),
98+
"render_id": render.render_id,
9799
"input": preview.input.model_dump(),
98100
"expires_at": str(result.data.expires_at),
99101
}

tests/test_preview_html.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,9 @@ async def test_preview_creative():
100100
assert result.success
101101
assert result.data
102102
assert len(result.data.previews) == 1
103+
# PreviewRender is a RootModel, access attributes via .root
103104
assert (
104-
str(result.data.previews[0].renders[0].preview_url)
105+
str(result.data.previews[0].renders[0].root.preview_url)
105106
== "https://preview.example.com/abc123"
106107
)
107108
mock_call.assert_called_once()

0 commit comments

Comments
 (0)