Incorporate Findings from Review

[BirgitBoss]

Findings via PR #10

Major Bugs:

• Technical Data Battery: correct expectedNumberOfCycle in TechnicalDataBattery (before NumberFullCycles)
• Nameplate mainly: correct Characteristic for MulitLanguageProperties to shared:MultiLanguageTexts
• Technical Data Battery: correct payload names for internalResistanceIncreaseOfBatteryCell, Pack and Module (denoted names for initialResistance)
• TechnicalData Battery: define new Characteristic :TemperatureRangeBoundary for temperature temperatureRangeIdleStateLowerBoundary and temperatureRangeIdleStateUpperBoundary (before it was range min/max but this would be redundant)
• Performance Battery: correct data type of capacitiyFade: does not have timestamp (BUG capacityFade does not have timestamp batterypass/BatteryPassDataModel#30) - not yet done
• Technical Data: fix property names of initialInternalResistanceOnBatteryCellLevel, PackLevel and ModuleLevel: remove Level, use "Of" instad of "on" to be consistent with DIN SPEC 91100 and internalResistanceIncreaseBattery*
• remove generated .aasx, .aas.xml and aas.json for SMT for which aasx is the master and not the aspect model because semanticIds of generated files and original files differ

Minor Bugs:

• fix bugs with respect to wrong language tags
• remove incorrect preferred names
• newly generated files
• new version of ESMF CLI was used: validation errors corrected
• remove duplicate definitions from .ttl files like :productOrSectorSpecificCarbonFootprints
• fix typos in element names

Major changes:

• update license information - no CC BY-NC 4.0 any longer for io.batterypass
• add enumeration and values for Contact Information
• • add enumeration and values for Markings
• PCF: add enumeration for LifeCyclePhases
• deviate from Contact Information recommendation and do not use IRDI as values if there is an enumeration and values defined
• use bp: <urn:samm:io.BatteryPass.Performance:1.2.1#> instead of bp: <urn:samm:io.BatteryPass.Performance:1.2.0#>
• use cx: <urn:samm:io.catenax.pcf:8.0.0#> instead of cx: <urn:samm:io.catenax.pcf:7.0.0#>
• add Namespace.ttl to HandoverDocumention, MaterialComposition, Circularity, ProductCondition. NOTE: not all namespaces already contain a Namespace.ttl
• new characteristics: Blob, RelationshipElement, split contentType because reused by both
• remove generated files related to aas because they will be contained in https://github.com/admin-shell-io/submodel-templates/tree/main/published
• add missing properties for TechnicalData
• add missing propoerties for HandoverDocumentation
• use DocumentIdentifierSet to reference documents in Handover Docu
• use Technical Data 2.0 instead of 1.2
• new: postalCode instead of zipCode

Improvements:

• update some preferred names
• add German preferred names for some properties
• add examples values for Nameplate und ContactInformation for MultiLanguageTexts #35 - Attention: they are not considered and may lead to validation errors in future
• add example values
• formatting
• fix typos
• new version of ESMF CLI was used: payload names now considered when generating json files etc.
• READMEs updated
• add see-attributes
• add payload names for starting with capital letter

Please be aware: some of the generated files also changed because of changes in reused Aspect Models from BatteryPass Consortium or Tractus-X/Catena-X, e.g.

DONE:
-- batterypass/BatteryPassDataModel#23: remove editorial special char from descriptions
-- batterypass/BatteryPassDataModel#25: Circularity.ValidEmailAddress wrong regex
-- batterypass/BatteryPassDataModel#27: GeneralProductInformation:1.2.0 exampleValue for addressCountry is wrong

OPEN:
-- batterypass/BatteryPassDataModel#32: NumberOfFullCycles and others should be xsd:positiveInteger
-- batterypass/BatteryPassDataModel#31 ratedEnergy/CertifiedUsableBatteryEnergy: data type & no negative values #31
-- batterypass/BatteryPassDataModel#21 add descriptions to properties
-- batterypass/BatteryPassDataModel#20 optional properties? Add cardinality to Performance, MaeterialComposition and Circularity properties
-- batterypass/BatteryPassDataModel#19 Add example values to Performance, MaeterialComposition and Circularity properties
-- batterypass/BatteryPassDataModel#36 correct typo from :kilogramperkilowatthour to :KilogramPerKilowattHour

• correct example value from samm:exampleValue "7439-93-2 " to samm:exampleValue "7439-93-2" .

Open issues for generated files (not relevant any longer since .aas files not included, they are manually edited):

• [BUG] SAMM2AASX Generator: SML handling, semanticId, payload Name and missing properties eclipse-esmf/esmf-sdk#766 [BUG] SAMM2AASX Generator: SML handling, semanticId, payload Name and missing properties

[hillgach]

HI @BirgitBoss , I'm not able to find this aspect model: urn:samm:io.BatteryPass.GeneralProductInformation:1.2.0#batteryStatus.

The same for circularity bp: urn:samm:io.BatteryPass.Circularity:1.2.0# .
bp:dismantlingAndRemovalInformation, bp:sparePartSources, bp:recycledContent, bp:safetyMeasures, bp:endOfLifeInformation, bp:renewableContent

I'm not able to completely resolve the DigitalNameplate nor Circularity

[BirgitBoss]

HI @BirgitBoss , I'm not able to find this aspect model: urn:samm:io.BatteryPass.GeneralProductInformation:1.2.0#batteryStatus.

The same for circularity bp: urn:samm:io.BatteryPass.Circularity:1.2.0# . bp:dismantlingAndRemovalInformation, bp:sparePartSources, bp:recycledContent, bp:safetyMeasures, bp:endOfLifeInformation, bp:renewableContent

I'm not able to completely resolve the DigitalNameplate nor Circularity

You need to include the aspect models from
https://github.com/batterypass/BatteryPassDataModel/tree/main/BatteryPass
properties and Characteristics of those are reused

Is mentioned in the README.md file

[hillgach]

HI @BirgitBoss , I'm not able to find this aspect model: urn:samm:io.BatteryPass.GeneralProductInformation:1.2.0#batteryStatus.
The same for circularity bp: urn:samm:io.BatteryPass.Circularity:1.2.0# . bp:dismantlingAndRemovalInformation, bp:sparePartSources, bp:recycledContent, bp:safetyMeasures, bp:endOfLifeInformation, bp:renewableContent
I'm not able to completely resolve the DigitalNameplate nor Circularity

You need to include the aspect models from https://github.com/batterypass/BatteryPassDataModel/tree/main/BatteryPass properties and Characteristics of those are reused

Is mentioned in the README.md file

The problem is not the mentioning on the README.md, but that some catenax reference models were directly copied to the repo (with antoher namespace). I though the intention was to keep the references on the repo

[T3-Uwe]

I would like to recommend to crosscheck whether the AAS battery pass attributes full fill the required EU Passport according to DIN DKE SPEC 99100. In case the mapping is incomplete we are not able to full fill the regulatories.

[BirgitBoss]

I would like to recommend to crosscheck whether the AAS battery pass attributes full fill the required EU Passport according to DIN DKE SPEC 99100. In case the mapping is incomplete we are not able to full fill the regulatories.

DIN DKE Spec 99100 is the basis for all of these models. Please let us know if you found some deviations like missing properties or too many properties etc., wrong data types etc.