Fix: handle numbers correct (#17) (closes #16)

* Fix: handle floats correct

* Test: add test case for floats

Author: aichbauer

src/helpers/check-special-chars-and-empty.js

@@ -1,7 +1,8 @@
 export const checkSpecialCharsAndEmpty = (value) => {
   const thisValue = value.toString().toLowerCase();
-
-  const hasSpecialChars = thisValue.includes('\n')
+  let hasSpecialChars = false;
+  if (typeof value === 'string') {
+    hasSpecialChars = thisValue.includes('\n')
     || thisValue.includes('\t')
     || thisValue.includes(',')
     || thisValue.includes(';')
@@ -12,6 +13,7 @@ export const checkSpecialCharsAndEmpty = (value) => {
     || thisValue.includes('´')
     || thisValue.includes(' ')
     || thisValue.length === 0;
+  }
 
   return hasSpecialChars;
 };

test/fixtures/data.js

@@ -26,6 +26,12 @@ const dataArrayWithZero = [
   [2, 'Larry', 'the Bird', '@twitter'],
 ];
 
+const dataArrayWithFloat = [
+  [1.001, 'Mark', 'Otto', '@mdo'],
+  [2.002, 'Jacob', 'Thornton', '@fat'],
+  [3.33, 'Larry', 'the Bird', '@twitter'],
+];
+
 const data = [
   {
     number: 1,
@@ -89,6 +95,27 @@ const dataWithNullAndUndefined = [
   },
 ];
 
+const dataWithFloat = [
+  {
+    number: 1.001,
+    first: 'Mark',
+    last: 'Otto',
+    handle: '@mdo',
+  },
+  {
+    number: 2.002,
+    first: 'Jacob',
+    last: 'Thornton',
+    handle: '@fat',
+  },
+  {
+    number: 3.33,
+    first: 'Larry',
+    last: 'the Bird',
+    handle: '@twitter',
+  },
+];
+
 export const dataArrayWithHeader = [
   ...headerArray,
   ...dataArray,
@@ -114,11 +141,20 @@ export const dataObjectWithNullAndUndefined = [
   ...dataWithNullAndUndefined,
 ];
 
+export const dataObjectWithFloat = [
+  ...dataWithFloat,
+];
+
 export const dataArrayWithHeaderAndNullAndUndefined = [
   ...headerArray,
   ...dataArrayWithNullAndUndefined,
 ];
 
+export const dataArrayWithHeaderAndFloats = [
+  ...headerArray,
+  ...dataArrayWithFloat,
+];
+
 export const dataArrayWithHeaderAndZero = [
   ...headerArray,
   ...dataArrayWithZero,

test/fixtures/expected-results.js

@@ -8,6 +8,10 @@ export const expectedResultObjectNullAndUndefined = 'Number,First,Last,Handle\n1
 
 export const expectedResultArrayNullAndUndefined = 'number,first,last,handle\n1,Mark,"",@mdo\n2,Jacob,Thornton,""\n3,Larry,"the Bird",@twitter\n';
 
+export const expectedResultArrayWithFloats = 'number,first,last,handle\n1.001,Mark,Otto,@mdo\n2.002,Jacob,Thornton,@fat\n3.33,Larry,"the Bird",@twitter\n';
+
+export const expectedResultObjectWithFloats = 'number,first,last,handle\n1.001,Mark,Otto,@mdo\n2.002,Jacob,Thornton,@fat\n3.33,Larry,"the Bird",@twitter\n';
+
 export const expectedResultArrayZero = 'number,first,last,handle\n0,Mark,Otto,@mdo\n1,Jacob,Thornton,@fat\n2,Larry,"the Bird",@twitter\n';
 
 export const expectedResultObjectHeaderSeparatorSemicolon = 'Number;First;Last;Handle\n1;Mark;Otto;@mdo\n2;Jacob;Thornton;@fat\n3;Larry;"the Bird";@twitter\n';

test/index.spec.js

@@ -8,7 +8,7 @@ import {
 import {
   expectedResultArrayNoHeaderNoOptions,
   expectedResultObjectNoOptions,
-  expectedResultArrayHeaderWithSpaces,gco 
+  expectedResultArrayHeaderWithSpaces,
 } from './fixtures/expected-results';
 import { optionsHeaderWithSpacesSeparatorDefault } from './fixtures/options';
 

test/modules/convert-array-of-arrays-to-csv.spec.js

@@ -6,6 +6,7 @@ import {
   dataArrayWithHeaderAndNullAndUndefined,
   dataArrayWithHeaderAndZero,
   dataArrayWithDoubleQuotesInsideElement,
+  dataArrayWithHeaderAndFloats,
 } from '../fixtures/data';
 import {
   optionsHeaderSeperatorSemicolon,
@@ -23,6 +24,7 @@ import {
   expectedResultArrayNullAndUndefined,
   expectedResultArrayZero,
   expectedResultArrayWithDoubleQoutesInsideElement,
+  expectedResultArrayWithFloats,
 } from '../fixtures/expected-results';
 
 test('convertArrayOfArraysToCSV | array of arrays | with default options', () => {
@@ -78,3 +80,9 @@ test('convertArrayOfArraysToCSV | array of arrays with value of zero | with defa
 
   expect(result).toBe(expectedResultArrayZero);
 });
+
+test('convertArrayOfArraysToCSV | array of arrays with floats | with default options and header', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithHeaderAndFloats, optionsDefault);
+
+  expect(result).toBe(expectedResultArrayWithFloats);
+});

test/modules/convert-array-of-objects-to-csv.spec.js

@@ -4,6 +4,7 @@ import {
   dataObject,
   dataObjectWithNullAndUndefined,
   dataObjectWithDoubleQuotesInsideElement,
+  dataObjectWithFloat,
 } from '../fixtures/data';
 import {
   optionsHeaderSeperatorSemicolon,
@@ -19,6 +20,7 @@ import {
   expectedResultObjecOnlySeparatorTab,
   expectedResultObjectNullAndUndefined,
   expectedResultObjectWithDoubleQoutesInsideElement,
+  expectedResultObjectWithFloats,
 } from '../fixtures/expected-results';
 
 test('convertArrayOfObjectsToCSV | array of objects | with default options', () => {
@@ -59,3 +61,9 @@ test('convertArrayOfObjectsToCSV | array of objects with values of null and unde
 
   expect(result).toBe(expectedResultObjectNullAndUndefined);
 });
+
+test('convertArrayOfObjectsToCSV | array of objects with float | options: default header', () => {
+  const result = convertArrayOfObjectsToCSV(dataObjectWithFloat, optionsDefault);
+
+  expect(result).toBe(expectedResultObjectWithFloats);
+});