Fix: pass options from index to modules (#1)

* Fix: pass options from index

* Test: update test for new options fix

Author: aichbauer

src/index.js

@@ -2,11 +2,11 @@ import { checkIfValid } from './helpers/check-if-valid';
 import { convertArrayOfArraysToCSV } from './modules/convert-array-of-arrays-to-csv';
 import { convertArrayOfObjectsToCSV } from './modules/convert-array-of-objects-to-csv';
 
-export const convertArrayToCSV = (data, { header, separator }) => {
+export const convertArrayToCSV = (data, { header, separator } = {}) => {
   checkIfValid(data);
 
   const thisOptions = {
-    header: header || undefined,
+    header,
     separator: separator || ',',
   };
 

src/modules/convert-array-of-arrays-to-csv.js

@@ -1,6 +1,6 @@
 import { checkSpecialCharsAndEmpty } from '../helpers/check-special-chars-and-empty';
 
-export const convertArrayOfArraysToCSV = (data, { header, separator } = {}) => {
+export const convertArrayOfArraysToCSV = (data, { header, separator }) => {
   const array = [...data];
   let csv = '';
 

src/modules/convert-array-of-objects-to-csv.js

@@ -1,6 +1,6 @@
 import { checkSpecialCharsAndEmpty } from '../helpers/check-special-chars-and-empty';
 
-export const convertArrayOfObjectsToCSV = (data, { header, separator } = {}) => {
+export const convertArrayOfObjectsToCSV = (data, { header, separator }) => {
   const array = [...data];
   let csv = '';
 

test/fixtures/options.js

@@ -1,12 +1,19 @@
-export const optionsOnlyHeader = {
+export const optionsHeaderSeparatorDefault = {
   header: ['Number', 'First', 'Last', 'Handle'],
+  separator: ',',
 };
 
 export const optionsHeaderSeperatorSemicolon = {
   header: ['Number', 'First', 'Last', 'Handle'],
   separator: ';',
 };
 
-export const optionsOnlySeperatorTab = {
+export const optionsHeaderDefaultSeperatorTab = {
+  header: undefined,
   separator: '\t',
 };
+
+export const optionsDefault = {
+  header: undefined,
+  separator: ',',
+};

test/modules/convert-array-of-arrays-to-csv.spec.js

@@ -6,8 +6,9 @@ import {
 } from '../fixtures/data';
 import {
   optionsHeaderSeperatorSemicolon,
-  optionsOnlyHeader,
-  optionsOnlySeperatorTab,
+  optionsHeaderSeparatorDefault,
+  optionsHeaderDefaultSeperatorTab,
+  optionsDefault,
 } from '../fixtures/options';
 
 import {
@@ -18,38 +19,38 @@ import {
   expectedResultArrayOnlySeparatorTab,
 } from '../fixtures/expected-results';
 
-test('convertArrayOfArraysToCSV | array of arrays | with no options', () => {
-  const result = convertArrayOfArraysToCSV(dataArrayWithHeader);
+test('convertArrayOfArraysToCSV | array of arrays | with default options', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithHeader, optionsDefault);
 
   expect(result).toBe(expectedResultArrayWithHeaderNoOptions);
 });
 
-test('convertArrayOfArraysToCSV | array of arrays | with no options and no header', () => {
-  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader);
+test('convertArrayOfArraysToCSV | array of arrays | with default options and no header', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader, optionsDefault);
 
   expect(result).toBe(expectedResultArrayNoHeaderNoOptions);
 });
 
-test('convertArrayOfArraysToCSV | array of arrays | with no options and no header', () => {
-  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader);
+test('convertArrayOfArraysToCSV | array of arrays | with default options and no header', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader, optionsDefault);
 
   expect(result).toBe(expectedResultArrayNoHeaderNoOptions);
 });
 
-test('convertArrayOfArraysToCSV | array of arrays | options: header + seperator semicolon', () => {
+test('convertArrayOfArraysToCSV | array of arrays | options: header + separator semicolon', () => {
   const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader, optionsHeaderSeperatorSemicolon);
 
   expect(result).toBe(expectedResultArrayHeaderSeparatorSemicolon);
 });
 
-test('convertArrayOfArraysToCSV | array of arrays | options: header ', () => {
-  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader, optionsOnlyHeader);
+test('convertArrayOfArraysToCSV | array of arrays | options: header + default separator', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithoutHeader, optionsHeaderSeparatorDefault);
 
   expect(result).toBe(expectedResultArrayOnlyHeader);
 });
 
-test('convertArrayOfArraysToCSV | array of arrays | options: separator tab ', () => {
-  const result = convertArrayOfArraysToCSV(dataArrayWithHeader, optionsOnlySeperatorTab);
+test('convertArrayOfArraysToCSV | array of arrays | options: default header + separator tab', () => {
+  const result = convertArrayOfArraysToCSV(dataArrayWithHeader, optionsHeaderDefaultSeperatorTab);
 
   expect(result).toBe(expectedResultArrayOnlySeparatorTab);
 });

test/modules/convert-array-of-objects-to-csv.spec.js

@@ -3,8 +3,9 @@ import { convertArrayOfObjectsToCSV } from '../../lib/modules/convert-array-of-o
 import { dataObject } from '../fixtures/data';
 import {
   optionsHeaderSeperatorSemicolon,
-  optionsOnlyHeader,
-  optionsOnlySeperatorTab,
+  optionsHeaderSeparatorDefault,
+  optionsHeaderDefaultSeperatorTab,
+  optionsDefault,
 } from '../fixtures/options';
 
 import {
@@ -14,26 +15,26 @@ import {
   expectedResultObjecOnlySeparatorTab,
 } from '../fixtures/expected-results';
 
-test('convertArrayOfObjectsToCSV | array of objects | with no options', () => {
-  const result = convertArrayOfObjectsToCSV(dataObject);
+test('convertArrayOfObjectsToCSV | array of objects | with default options', () => {
+  const result = convertArrayOfObjectsToCSV(dataObject, optionsDefault);
 
   expect(result).toBe(expectedResultObjectNoOptions);
 });
 
-test('convertArrayOfObjectsToCSV | array of objects | options: header + seperator semicolon', () => {
+test('convertArrayOfObjectsToCSV | array of objects | options: header + separator semicolon', () => {
   const result = convertArrayOfObjectsToCSV(dataObject, optionsHeaderSeperatorSemicolon);
 
   expect(result).toBe(expectedResultObjectHeaderSeparatorSemicolon);
 });
 
-test('convertArrayOfObjectsToCSV | array of objects | options: header', () => {
-  const result = convertArrayOfObjectsToCSV(dataObject, optionsOnlyHeader);
+test('convertArrayOfObjectsToCSV | array of objects | options: header + default separator', () => {
+  const result = convertArrayOfObjectsToCSV(dataObject, optionsHeaderSeparatorDefault);
 
   expect(result).toBe(expectedResultObjectOnlyHeader);
 });
 
-test('convertArrayOfObjectsToCSV | array of objects | options: separator tab', () => {
-  const result = convertArrayOfObjectsToCSV(dataObject, optionsOnlySeperatorTab);
+test('convertArrayOfObjectsToCSV | array of objects | options: default header + separator tab', () => {
+  const result = convertArrayOfObjectsToCSV(dataObject, optionsHeaderDefaultSeperatorTab);
 
   expect(result).toBe(expectedResultObjecOnlySeparatorTab);
 });