Fix implicitly nullable parameter for PHP 8.4 compatibility (#24)

GromNaN · web-flow · commit 0301d6810596 · 2024-09-19T07:27:33.000+02:00
* Fix implicitly nullable parameter
* Run tests on newest PHP versions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -27,6 +27,15 @@ jobs:
           - operating-system: 'ubuntu-latest'
             php-version: '8.1'
 
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.2'
+
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.3'
+
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.4'
+
           - operating-system: 'windows-latest'
             php-version: '8.1'
             job-description: 'on Windows'
diff --git a/src/AsyncTestCase.php b/src/AsyncTestCase.php
@@ -241,7 +241,7 @@ final protected function setTimeout(int $timeout)
      *
      * @return callable|MockObject Mock object having only an __invoke method.
      */
-    final protected function createCallback(int $invocationCount, callable $returnCallback = null): callable
+    final protected function createCallback(int $invocationCount, ?callable $returnCallback = null): callable
     {
         $mock = $this->createMock(CallbackStub::class);
         $invocationMocker = $mock->expects($this->exactly($invocationCount))

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ final protected function setTimeout(int $timeout)`
`241`	`241`	`*`
`242`	`242`	`* @return callable\|MockObject Mock object having only an __invoke method.`
`243`	`243`	`*/`
`244`		`- final protected function createCallback(int $invocationCount, callable $returnCallback = null): callable`
	`244`	`+ final protected function createCallback(int $invocationCount, ?callable $returnCallback = null): callable`
`245`	`245`	`{`
`246`	`246`	`$mock = $this->createMock(CallbackStub::class);`
`247`	`247`	`$invocationMocker = $mock->expects($this->exactly($invocationCount))`