-
Notifications
You must be signed in to change notification settings - Fork 0
С# Based with Liquid Glass v0.9a #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| private static LoadedImage LoadStaticInternal(string path, string extension, CancellationToken cancellationToken) | ||
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| try | ||
| { | ||
| using var stream = File.OpenRead(path); | ||
| var bitmap = new Bitmap(stream); | ||
| var metadata = MetadataBuilder.Build(path, bitmap.PixelSize, false, bitmap, null); | ||
| return new LoadedImage(path, bitmap, null, metadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Respect EXIF orientation for standard image formats
Static image loading that falls through LoadStaticInternal constructs an Avalonia Bitmap directly from the file stream without applying EXIF orientation. Only the Magick-based paths call AutoOrient, so common formats such as .jpg or .jpeg that carry orientation metadata but are not in MagickStaticExtensions will be displayed sideways or upside down. Consider normalizing orientation for all static loads (e.g. via ImageMagick or ImageSharp) before building the Bitmap and metadata.
Useful? React with 👍 / 👎.
No description provided.