fix(PeriphDrivers): MSDK-1337: CRC calculation issues #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dung Nguyen <dung.nguyen@analog.com>
github-actions
bot
added
MAX32655
|
This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days. |
ttmut
requested changes
Nov 28, 2025
Comment on lines
-122
to
-127
| if (fail != 0) { | ||
| printf("\nExample Failed\n"); | ||
| return E_FAIL; | ||
| } | ||
| run_demo_crc(0); | ||
| run_demo_crc(1); | ||
|
|
||
| while (1) {} | ||
|
|
||
| printf("\nExample Succeeded\n"); |
Contributor
There was a problem hiding this comment.
Instead of using an infinite loop, please implement a wait flag as in the previous version of this example so the code prints the test result once it completes. CI system relies on "Example Succeeded" string to determine the test result. See https://github.com/analogdevicesinc/msdk/blob/main/.github/workflows/scripts/example_tester_78002.sh#L222
Contributor
|
CRC header and example for MAX32680 need to be updated as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CRC calculation issues and Update CRC examples.
Checklist Before Requesting Review