Skip to content
This repository was archived by the owner on Feb 25, 2018. It is now read-only.
This repository was archived by the owner on Feb 25, 2018. It is now read-only.

Reason for inclusion of all files? #148

@scarstens

Description

@scarstens

https://github.com/apotropaic/parse.com-php-library/blob/master/parse.php#L2

  1. These are class files, why are we not using "include_once" here?
  2. Is there a reason why you are including all files? Its very inefficient to load everything they way you do. All of the extension classes should instead include the parent class, and/or any other dependencies.

Example:

  • parse.php (should have no additional include files... except for Config, though I'm not thrilled about the use of the config class in general and think the config params should be part of the class instantiation.
  • parseObject.php (should include_once the parse.php file)
    Result: I can include parseObject.php, it will load the dependency class, and I can then work with objects, without loading all the other classes I'm not using.

If there is not some reason for this, I'll include the fixes to this in my next pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions