build-djgpp.sh requires sudo privileges to build and install in /usr/local/

[volkertb]

Hi there,

First of all, awesome project. This script really saves people a lot of time. 😃

The issue I'm reporting here is a minor one: by default, the script installs the cross-compiler and tools in /usr/local/djgpp/. However, on most systems, /usr/local/ is not writable for non-root users, so the script will have to be run with sudo privileges, unless an alternative DJGPP_PREFIX somewhere in the user's home folder is specified.

It might be helpful to clarify this in the README.md file.

Thanks and keep up the good work!

[stsp]

I also ran into this problem.
I think the compilation and installation
should be done by separate scripts,
with the second one being run with sudo.

[volkertb]

I agree with @stsp. That would be in line with how most Unix/Linux makefiles work, with the compilation being done with "make" and the installation being done with "sudo make install" (or just "make install" when a non-privileged installation folder is specified).

[stsp]

There seem to be a very extensive build
script rework pending: #25.
@jwt27 could you please hint us if your
patch set addresses also this?

[jwt27]

I hadn't really considered this to be an issue. There is already a check in place to test if you have write access to the installation directory:

build-djgpp/script/7.2.0

Lines 134 to 146 in 4180d92

	# create target directory, check writable.
	echo "Make prefix directory : $DJGPP_PREFIX"
	mkdir -p $DJGPP_PREFIX
	if ! [ -d $DJGPP_PREFIX ]; then
	echo "Unable to create prefix directory"
	exit 1
	fi
	if ! [ -w $DJGPP_PREFIX ]; then
	echo "prefix directory is not writable."
	exit 1
	fi

https://github.com/jwt27/build-gcc/blob/a8b3e194289c4f29dc820a30c0b5a4bd52de30d9/script/download.sh#L127-L139

I suppose this check could be moved up earlier in the script, before the download phase. Splitting up into separate build/install scripts makes things more complicated, since building gcc requires binutils and the libc headers to be installed first.

[stsp]

libc headers to be installed first.

Ahh, indeed. :(
I wonder how can this be then solved properly.
fakechroot? Too complicated.
Maybe the build scripts should run sudo
themselves before doing the install things,
and the user will have to type the password
from time to time? Doh.

[jwt27]

Maybe the build scripts should run sudo
themselves before doing the install things,
and the user will have to type the password
from time to time? Doh.

That's an option, albeit somewhat inconvenient. I'll look into it.

[stsp]

Thank you!
Please note that it will do so only if the
write perms are missing by default, so
at least no one from current users would
get sufficiently hurt by such change.

[jwt27]

See branch sudo on my fork: https://github.com/jwt27/build-gcc/tree/sudo

I am unable to test this myself, being on mingw64 (where sudo doesn't even exist)

[stsp]

You are quick!
Trying now...

[stsp]

First problem: bash (at least on ubuntu)
doesn't seem to like DOSish line endings.
Had to do dos2unix on scripts before they
could be started.

[stsp]

If you wish to change anything, press CTRL-C now. Otherwise, press any other key to continue.
[sudo] password for stas: 
Download source files...
Download http://www.delorie.com/pub/djgpp/current/v2gnu/bnu2311s.zip ...

I wonder why it asked the password before even
starting the download. Does this make any sense?

[jwt27]

First problem: bash (at least on ubuntu)
doesn't seem to like DOSish line endings.
Had to do dos2unix on scripts before they
could be started.

That's interesting.. I thought git converts line endings automatically? Will need to check my settings.

I wonder why it asked the password before even
starting the download. Does this make any sense?

That is to create the PREFIX directory. You're right, it doesn't make much sense to do that before downloading.

[stsp]

That is to create the PREFIX directory.

Maybe, but now I restarted the script, and
it did the same thing again! (asked the sudo
passwd beforehand). Presumably the PREFIX
dir was already created on the second start,
so there is some bug.

[stsp]

chmod a+x install-sh
chmod a+x missing
/home/stas/src/build-gcc/script/build-binutils.sh: line 9: ../configure: Permission denied

You forgot to chmod also configure.

[stsp]

I wonder how to give the user a confidence
that he isn't working as root most of the time.
Maybe after you ended the sudo operation,
you should print what was done under root,
and say that after a kepress the root privs
will be dropped. Or overkill?