Migrate everything to media3's Log

nift4 · nift4 · commit c93d3e6e163d · 2025-10-09T12:51:36.000+02:00
To consistently allow apps to intercept logs and just be generally
consistent in the project.
diff --git a/demos/composition/src/main/java/androidx/media3/demo/composition/effect/DemoLottieProvider.kt b/demos/composition/src/main/java/androidx/media3/demo/composition/effect/DemoLottieProvider.kt
@@ -20,9 +20,9 @@ import android.graphics.Bitmap
 import android.graphics.BitmapFactory
 import android.graphics.Typeface
 import android.util.Base64
-import android.util.Log
 import androidx.core.graphics.createBitmap
 import androidx.core.graphics.scale
+import androidx.media3.common.util.Log
 import androidx.media3.common.util.UnstableApi
 import androidx.media3.effect.LottieOverlay
 import com.airbnb.lottie.ImageAssetDelegate
diff --git a/demos/effect/src/main/java/androidx/media3/demo/effect/EffectDemoUtil.kt b/demos/effect/src/main/java/androidx/media3/demo/effect/EffectDemoUtil.kt
@@ -18,8 +18,8 @@ package androidx.media3.demo.effect
 import android.content.Context
 import android.net.Uri
 import android.util.JsonReader
-import android.util.Log
 import androidx.media3.common.MediaItem
+import androidx.media3.common.util.Log
 import java.io.IOException
 import java.io.InputStreamReader
 import java.nio.charset.StandardCharsets
diff --git a/demos/main/src/main/java/androidx/media3/demo/main/SampleChooserActivity.java b/demos/main/src/main/java/androidx/media3/demo/main/SampleChooserActivity.java
@@ -32,7 +32,6 @@
 import android.os.Looper;
 import android.text.TextUtils;
 import android.util.JsonReader;
-import android.util.Log;
 import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
@@ -53,6 +52,7 @@
 import androidx.media3.common.MediaItem;
 import androidx.media3.common.MediaItem.ClippingConfiguration;
 import androidx.media3.common.MediaMetadata;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.UnstableApi;
 import androidx.media3.common.util.Util;
 import androidx.media3.datasource.DataSource;
diff --git a/demos/session/src/main/java/androidx/media3/demo/session/PlayerActivity.kt b/demos/session/src/main/java/androidx/media3/demo/session/PlayerActivity.kt
@@ -18,7 +18,6 @@ package androidx.media3.demo.session
 import android.content.ComponentName
 import android.content.Context
 import android.os.Bundle
-import android.util.Log
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
@@ -40,6 +39,7 @@ import androidx.media3.common.Player.EVENT_MEDIA_ITEM_TRANSITION
 import androidx.media3.common.Player.EVENT_MEDIA_METADATA_CHANGED
 import androidx.media3.common.Player.EVENT_TIMELINE_CHANGED
 import androidx.media3.common.Player.EVENT_TRACKS_CHANGED
+import androidx.media3.common.util.Log
 import androidx.media3.common.util.UnstableApi
 import androidx.media3.session.MediaController
 import androidx.media3.session.SessionToken
diff --git a/demos/shortform/src/main/java/androidx/media3/demo/shortform/viewpager/ViewPagerActivity.kt b/demos/shortform/src/main/java/androidx/media3/demo/shortform/viewpager/ViewPagerActivity.kt
@@ -16,8 +16,8 @@
 package androidx.media3.demo.shortform.viewpager
 
 import android.os.Bundle
-import android.util.Log
 import androidx.appcompat.app.AppCompatActivity
+import androidx.media3.common.util.Log
 import androidx.media3.demo.shortform.MainActivity
 import androidx.media3.demo.shortform.MediaItemDatabase
 import androidx.media3.demo.shortform.R
diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/VideoDecoderGLSurfaceView.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/VideoDecoderGLSurfaceView.java
@@ -22,10 +22,10 @@
 import android.opengl.GLES20;
 import android.opengl.GLSurfaceView;
 import android.util.AttributeSet;
-import android.util.Log;
 import androidx.annotation.Nullable;
 import androidx.media3.common.util.GlProgram;
 import androidx.media3.common.util.GlUtil;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.NullableType;
 import androidx.media3.common.util.UnstableApi;
 import androidx.media3.decoder.VideoDecoderOutputBuffer;
diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/spherical/ProjectionRenderer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/spherical/ProjectionRenderer.java
@@ -19,11 +19,11 @@
 
 import android.opengl.GLES11Ext;
 import android.opengl.GLES20;
-import android.util.Log;
 import androidx.annotation.Nullable;
 import androidx.media3.common.C;
 import androidx.media3.common.util.GlProgram;
 import androidx.media3.common.util.GlUtil;
+import androidx.media3.common.util.Log;
 import java.nio.FloatBuffer;
 import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
 
diff --git a/libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpPcmReader.java b/libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpPcmReader.java
@@ -18,8 +18,8 @@
 import static androidx.media3.exoplayer.rtsp.reader.RtpReaderUtils.toSampleTimeUs;
 import static com.google.common.base.Preconditions.checkNotNull;
 
-import android.util.Log;
 import androidx.media3.common.C;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.ParsableByteArray;
 import androidx.media3.common.util.UnstableApi;
 import androidx.media3.common.util.Util;
diff --git a/libraries/session/src/main/java/androidx/media3/session/MediaButtonReceiver.java b/libraries/session/src/main/java/androidx/media3/session/MediaButtonReceiver.java
@@ -140,7 +140,7 @@ protected final void handleIntentAndMaybeStartTheService(
     if (intent == null
         || !Objects.equals(intent.getAction(), Intent.ACTION_MEDIA_BUTTON)
         || !intent.hasExtra(Intent.EXTRA_KEY_EVENT)) {
-      android.util.Log.d(TAG, "Ignore unsupported intent: " + intent);
+      Log.d(TAG, "Ignore unsupported intent: " + intent);
       return;
     }
 
@@ -163,7 +163,7 @@ protected final void handleIntentAndMaybeStartTheService(
         // playback is started and the MediaSessionService/MediaLibraryService is put into the
         // foreground (see https://developer.android.com/media/legacy/media-buttons and
         // https://developer.android.com/about/versions/oreo/android-8.0-changes#back-all).
-        android.util.Log.w(
+        Log.w(
             TAG,
             "Ignore key event that is not a `play` command on API 26 or above to avoid an"
                 + " 'ForegroundServiceDidNotStartInTimeException'");
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserCompat.java
@@ -65,12 +65,12 @@
 import android.os.RemoteException;
 import android.support.v4.os.ResultReceiver;
 import android.text.TextUtils;
-import android.util.Log;
 import androidx.annotation.IntDef;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
 import androidx.annotation.RestrictTo;
 import androidx.collection.ArrayMap;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.NullableType;
 import androidx.media3.session.legacy.MediaControllerCompat.TransportControls;
 import java.lang.annotation.Retention;
@@ -108,7 +108,6 @@
 @RestrictTo(LIBRARY)
 public final class MediaBrowserCompat {
   static final String TAG = "MediaBrowserCompat";
-  static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
 
   /**
    * Used as an int extra field to denote the page number to subscribe. The value of {@code
@@ -1219,9 +1218,7 @@ public void onLoadChildren(
       // Check that the subscription is still subscribed.
       Subscription subscription = parentId == null ? null : subscriptions.get(parentId);
       if (subscription == null) {
-        if (DEBUG) {
-          Log.d(TAG, "onLoadChildren for id that isn't subscribed id=" + parentId);
-        }
+        Log.d(TAG, "onLoadChildren for id that isn't subscribed id=" + parentId);
         return;
       }
 
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserServiceCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserServiceCompat.java
@@ -66,7 +66,6 @@
 import android.service.media.MediaBrowserService;
 import android.support.v4.os.ResultReceiver;
 import android.text.TextUtils;
-import android.util.Log;
 import androidx.annotation.CallSuper;
 import androidx.annotation.IntDef;
 import androidx.annotation.MainThread;
@@ -75,6 +74,7 @@
 import androidx.annotation.RestrictTo;
 import androidx.collection.ArrayMap;
 import androidx.core.util.Pair;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.NullableType;
 import androidx.media3.common.util.Util;
 import androidx.media3.session.legacy.MediaSessionManager.RemoteUserInfo;
@@ -119,7 +119,6 @@
 @RestrictTo(LIBRARY)
 public abstract class MediaBrowserServiceCompat extends Service {
   static final String TAG = "MBServiceCompat";
-  static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
 
   private static final float EPSILON = 0.00001f;
 
@@ -1542,15 +1541,13 @@ void performLoadChildren(
           @Override
           void onResultSent(@Nullable List<MediaBrowserCompat.MediaItem> list) {
             if (connections.get(checkNotNull(connection.callbacks).asBinder()) != connection) {
-              if (DEBUG) {
-                Log.d(
-                    TAG,
-                    "Not sending onLoadChildren result for connection that has"
-                        + " been disconnected. pkg="
-                        + connection.pkg
-                        + " id="
-                        + parentId);
-              }
+              Log.d(
+                  TAG,
+                  "Not sending onLoadChildren result for connection that has"
+                      + " been disconnected. pkg="
+                      + connection.pkg
+                      + " id="
+                      + parentId);
               return;
             }
 
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaButtonReceiver.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaButtonReceiver.java
@@ -27,12 +27,12 @@
 import android.content.pm.PackageManager;
 import android.content.pm.ResolveInfo;
 import android.os.Build;
-import android.util.Log;
 import android.view.KeyEvent;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
 import androidx.annotation.RestrictTo;
 import androidx.core.content.ContextCompat;
+import androidx.media3.common.util.Log;
 import java.util.List;
 
 /**
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaControllerCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaControllerCompat.java
@@ -39,13 +39,13 @@
 import android.os.RemoteException;
 import android.os.ResultReceiver;
 import android.text.TextUtils;
-import android.util.Log;
 import android.view.KeyEvent;
 import androidx.annotation.GuardedBy;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
 import androidx.annotation.RestrictTo;
 import androidx.media3.common.AudioAttributes;
+import androidx.media3.common.util.Log;
 import androidx.media3.session.legacy.MediaSessionCompat.QueueItem;
 import androidx.media3.session.legacy.PlaybackStateCompat.CustomAction;
 import androidx.versionedparcelable.ParcelUtils;
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaMetadataCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaMetadataCompat.java
@@ -25,11 +25,11 @@
 import android.os.Bundle;
 import android.os.Parcel;
 import android.os.Parcelable;
-import android.util.Log;
 import androidx.annotation.Nullable;
 import androidx.annotation.RestrictTo;
 import androidx.annotation.StringDef;
 import androidx.collection.ArrayMap;
+import androidx.media3.common.util.Log;
 import androidx.media3.session.legacy.MediaControllerCompat.TransportControls;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionCompat.java
@@ -49,14 +49,14 @@
 import android.os.ResultReceiver;
 import android.os.SystemClock;
 import android.text.TextUtils;
-import android.util.Log;
 import android.view.KeyEvent;
 import android.view.ViewConfiguration;
 import androidx.annotation.GuardedBy;
 import androidx.annotation.IntDef;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
 import androidx.annotation.RestrictTo;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.NullableType;
 import androidx.media3.session.legacy.MediaSessionManager.RemoteUserInfo;
 import androidx.versionedparcelable.ParcelUtils;
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionManager.java b/libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionManager.java
@@ -26,11 +26,11 @@
 import android.os.Process;
 import android.provider.Settings;
 import android.text.TextUtils;
-import android.util.Log;
 import androidx.annotation.Nullable;
 import androidx.annotation.RequiresApi;
 import androidx.annotation.RestrictTo;
 import androidx.core.util.ObjectsCompat;
+import androidx.media3.common.util.Log;
 
 /**
  * Provides support for interacting with {@link MediaSessionCompat media sessions} that applications
@@ -42,7 +42,6 @@
 @RestrictTo(LIBRARY)
 public final class MediaSessionManager {
   static final String TAG = "MediaSessionManager";
-  static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
 
   private static final Object lock = new Object();
   @Nullable private static volatile MediaSessionManager sessionManager;
@@ -218,7 +217,6 @@ public int hashCode() {
 
   private static class MediaSessionManagerImpl {
     private static final String TAG = MediaSessionManager.TAG;
-    private static final boolean DEBUG = MediaSessionManager.DEBUG;
 
     private static final String PERMISSION_STATUS_BAR_SERVICE =
         "android.permission.STATUS_BAR_SERVICE";
@@ -254,9 +252,7 @@ public boolean isTrustedForMediaControl(MediaSessionManager.RemoteUserInfoImpl u
           return false;
         }
       } catch (PackageManager.NameNotFoundException e) {
-        if (DEBUG) {
-          Log.d(TAG, "Package " + userInfo.getPackageName() + " doesn't exist");
-        }
+        Log.d(TAG, "Package " + userInfo.getPackageName() + " doesn't exist");
         return false;
       }
       return isPermissionGranted(userInfo, PERMISSION_STATUS_BAR_SERVICE)
diff --git a/libraries/session/src/main/java/androidx/media3/session/legacy/RatingCompat.java b/libraries/session/src/main/java/androidx/media3/session/legacy/RatingCompat.java
@@ -22,10 +22,10 @@
 import android.media.Rating;
 import android.os.Parcel;
 import android.os.Parcelable;
-import android.util.Log;
 import androidx.annotation.IntDef;
 import androidx.annotation.Nullable;
 import androidx.annotation.RestrictTo;
+import androidx.media3.common.util.Log;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 
diff --git a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java
@@ -24,7 +24,7 @@
 import static com.google.common.truth.Truth.assertThat;
 
 import android.content.Context;
-import android.util.Log;
+import androidx.media3.common.util.Log;
 import androidx.media3.effect.Presentation;
 import androidx.media3.transformer.ParameterizedAndroidTestUtil.SdrImageItemConfig;
 import androidx.media3.transformer.ParameterizedAndroidTestUtil.SequenceConfig;
diff --git a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/ToneMapHdrToSdrUsingOpenGlPixelTest.java b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/ToneMapHdrToSdrUsingOpenGlPixelTest.java
@@ -25,10 +25,10 @@
 
 import android.graphics.Bitmap;
 import android.os.Build;
-import android.util.Log;
 import androidx.media3.common.C;
 import androidx.media3.common.ColorInfo;
 import androidx.media3.common.Format;
+import androidx.media3.common.util.Log;
 import androidx.media3.effect.DefaultVideoFrameProcessor;
 import androidx.media3.test.utils.VideoFrameProcessorTestRunner;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java b/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java
@@ -46,7 +46,6 @@
 import android.os.HandlerThread;
 import android.os.Looper;
 import android.os.Message;
-import android.util.Log;
 import android.util.SparseArray;
 import androidx.annotation.GuardedBy;
 import androidx.annotation.IntDef;
@@ -63,6 +62,7 @@
 import androidx.media3.common.util.Clock;
 import androidx.media3.common.util.ConditionVariable;
 import androidx.media3.common.util.HandlerWrapper;
+import androidx.media3.common.util.Log;
 import androidx.media3.common.util.Util;
 import androidx.media3.effect.DebugTraceUtil;
 import androidx.media3.muxer.MuxerException;
