From 1e151b36b86ab0dc1f67bc8b2db6dc866b4b12a4 Mon Sep 17 00:00:00 2001
From: Ankit Kalauni <70426091+Ankitkalauni@users.noreply.github.com>
Date: Sat, 27 Jan 2024 21:01:58 +0530
Subject: [PATCH 1/3] Updated  smartConnect.py generateSession()

Handles the failure of generateSession.

the request returns success = False on failure, with a message which is logged and returned.
---
 SmartApi/smartConnect.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/SmartApi/smartConnect.py b/SmartApi/smartConnect.py
index 2ea0f72e..d871612f 100644
--- a/SmartApi/smartConnect.py
+++ b/SmartApi/smartConnect.py
@@ -234,6 +234,11 @@ def generateSession(self,clientCode,password,totp):
         
         params={"clientcode":clientCode,"password":password,"totp":totp}
         loginResultObject=self._postRequest("api.login",params)
+
+        if loginResultObject['status']==False:
+            #on failure returns the error message
+            logger.error(f"API User Session Failed: {loginResultObject['message']}")
+            return loginResultObject['message']
         
         if loginResultObject['status']==True:
             jwtToken=loginResultObject['data']['jwtToken']

From 765c5c62d7724b59e3f1e8e0bd559d9bedbb0075 Mon Sep 17 00:00:00 2001
From: Ankit Kalauni <70426091+Ankitkalauni@users.noreply.github.com>
Date: Sat, 27 Jan 2024 21:15:18 +0530
Subject: [PATCH 2/3] Update smartConnect.py

updated the failure on login
---
 SmartApi/smartConnect.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SmartApi/smartConnect.py b/SmartApi/smartConnect.py
index d871612f..4dde1962 100644
--- a/SmartApi/smartConnect.py
+++ b/SmartApi/smartConnect.py
@@ -235,7 +235,7 @@ def generateSession(self,clientCode,password,totp):
         params={"clientcode":clientCode,"password":password,"totp":totp}
         loginResultObject=self._postRequest("api.login",params)
 
-        if loginResultObject['status']==False:
+        if loginResultObject['success']==False:
             #on failure returns the error message
             logger.error(f"API User Session Failed: {loginResultObject['message']}")
             return loginResultObject['message']

From c4e5f9f059887ccee36483ba86409178936b0612 Mon Sep 17 00:00:00 2001
From: Ankit Kalauni <70426091+Ankitkalauni@users.noreply.github.com>
Date: Mon, 29 Jan 2024 16:03:47 +0530
Subject: [PATCH 3/3] Update smartConnect.py

---
 SmartApi/smartConnect.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/SmartApi/smartConnect.py b/SmartApi/smartConnect.py
index 4dde1962..377ff720 100644
--- a/SmartApi/smartConnect.py
+++ b/SmartApi/smartConnect.py
@@ -235,10 +235,15 @@ def generateSession(self,clientCode,password,totp):
         params={"clientcode":clientCode,"password":password,"totp":totp}
         loginResultObject=self._postRequest("api.login",params)
 
-        if loginResultObject['success']==False:
-            #on failure returns the error message
-            logger.error(f"API User Session Failed: {loginResultObject['message']}")
-            return loginResultObject['message']
+        # return loginResultObject
+        try:
+            if loginResultObject['success']==False:
+                #on failure returns the error message       
+                logger.error(f"API User Session Failed: {loginResultObject['message']}")
+                return loginResultObject['message']
+        
+        except:
+            pass
         
         if loginResultObject['status']==True:
             jwtToken=loginResultObject['data']['jwtToken']