feat: support configuring chat context in AI assistant #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
approved these changes
Oct 29, 2025
crisbeto
reviewed
Oct 29, 2025
runner/shared-interfaces.ts
Outdated
| */ | ||
| export interface AssessmentResult { | ||
| /** Unique ID of the app result. Set by the `report-server` when fetching. */ | ||
| id?: string; |
There was a problem hiding this comment.
Since this interface is also meant to reflect the data on disk, would it make sense to declare something specifically for the report app? E.g. type AssessmentResultWithId = AssessmentResult & {id: string}.
There was a problem hiding this comment.
Updated. Added a new type AssessmentResultFromReportServer.
devversion
force-pushed
the
ai-assist-context
branch
from
3626db3 to
06c6d33
Compare
crisbeto
approved these changes
Oct 30, 2025
This is important for reports with many apps, or many checks. The model limits can be easily hit.
devversion
force-pushed
the
ai-assist-context
branch
from
06c6d33 to
a3e39ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for reports with many apps, or many checks. The model limits can be easily hit.