diff --git a/ch3_pull-request/Create-PullRequest.md b/ch3_pull-request/Create-PullRequest.md index 3cd961b2..1e69fb23 100644 --- a/ch3_pull-request/Create-PullRequest.md +++ b/ch3_pull-request/Create-PullRequest.md @@ -6,7 +6,7 @@ In Chapter 3 - _Teamwork and Collaborative Development_ we learn how to collabo 2. Delete the following line: - __Delete this line__ +It was a simple tip of the hat. Grace didn't think that anyone else besides her had even noticed it. It wasn't anything that the average person would notice, let alone remember at the end of the day. That's why it seemed so unbelievable that this little gesture would ultimately change the course of the world. 3. Add one or two lines here with a random text: @@ -14,7 +14,7 @@ In Chapter 3 - _Teamwork and Collaborative Development_ we learn how to collabo 4. Modify the following line by removing the letters that do not belong: - __---> The ccow jumpedd ovverr thhe mooon__ + __---> The cow jumped over the moon__ 5. Commit your changes into a new _branch_: @@ -41,3 +41,5 @@ In Chapter 3 - _Teamwork and Collaborative Development_ we learn how to collabo Navigate back to the pull request and note that you can review the file with all changes (`Files changed`) or individual `Commits`. You can comment in both views. ![Changes](img/changes.png) + +The shoes had been there for as long as anyone could remember. In fact, it was difficult for anyone to come up with a date they had first appeared. It had seemed they'd always been there and yet they seemed so out of place. Why nobody had removed them was a question that had been asked time and again, but while they all thought it, nobody had ever found the energy to actually do it. So, the shoes remained on the steps, out of place in one sense, but perfectly normal in another. diff --git a/ch3_pull-request/src/app.js b/ch3_pull-request/src/app.js index d2b448d1..ed478479 100644 --- a/ch3_pull-request/src/app.js +++ b/ch3_pull-request/src/app.js @@ -1,5 +1,14 @@ function toRomanNumerals(num) { - return num; + var lookup = { M:1000,CM:900,D:500,CD:400,C:100,XC:90,L:50,XL:40,X:10,IX:9,V:5,IV:4,I:1 }; + var roman = ''; + var i; + for ( i in lookup ) { + while ( num >= lookup[i] ) { + roman += i; + num -= lookup[i]; + } + } + return roman; } var numbers = [3,4,5,13,42,2021];