From 286c374540f43782c9ada83734a097791e92d4ce Mon Sep 17 00:00:00 2001 From: animedragonfighter Date: Tue, 20 Jan 2026 11:59:01 -0600 Subject: [PATCH 1/3] Modify Readme.md Modify the readme to test pull request features Signed-off-by: animedragonfighter --- ch3_pull-request/Create-PullRequest.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ch3_pull-request/Create-PullRequest.md b/ch3_pull-request/Create-PullRequest.md index 3cd961b2..9e889c9b 100644 --- a/ch3_pull-request/Create-PullRequest.md +++ b/ch3_pull-request/Create-PullRequest.md @@ -6,7 +6,7 @@ In Chapter 3 - _Teamwork and Collaborative Development_ we learn how to collabo 2. Delete the following line: - __Delete this line__ +It was a simple tip of the hat. Grace didn't think that anyone else besides her had even noticed it. It wasn't anything that the average person would notice, let alone remember at the end of the day. That's why it seemed so unbelievable that this little gesture would ultimately change the course of the world. 3. Add one or two lines here with a random text: From 01aef290128ca061805221035ec5c831591c8323 Mon Sep 17 00:00:00 2001 From: animedragonfighter Date: Tue, 20 Jan 2026 13:22:51 -0600 Subject: [PATCH 2/3] Update Create-PullRequest.md Added a new line Signed-off-by: animedragonfighter --- ch3_pull-request/Create-PullRequest.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ch3_pull-request/Create-PullRequest.md b/ch3_pull-request/Create-PullRequest.md index 9e889c9b..1e69fb23 100644 --- a/ch3_pull-request/Create-PullRequest.md +++ b/ch3_pull-request/Create-PullRequest.md @@ -14,7 +14,7 @@ It was a simple tip of the hat. Grace didn't think that anyone else besides her 4. Modify the following line by removing the letters that do not belong: - __---> The ccow jumpedd ovverr thhe mooon__ + __---> The cow jumped over the moon__ 5. Commit your changes into a new _branch_: @@ -41,3 +41,5 @@ It was a simple tip of the hat. Grace didn't think that anyone else besides her Navigate back to the pull request and note that you can review the file with all changes (`Files changed`) or individual `Commits`. You can comment in both views. ![Changes](img/changes.png) + +The shoes had been there for as long as anyone could remember. In fact, it was difficult for anyone to come up with a date they had first appeared. It had seemed they'd always been there and yet they seemed so out of place. Why nobody had removed them was a question that had been asked time and again, but while they all thought it, nobody had ever found the energy to actually do it. So, the shoes remained on the steps, out of place in one sense, but perfectly normal in another. From a74a4ede3dfda4e80f6e85fd0ddb042249346026 Mon Sep 17 00:00:00 2001 From: animedragonfighter Date: Tue, 20 Jan 2026 15:59:52 -0600 Subject: [PATCH 3/3] Update app.js Signed-off-by: animedragonfighter --- ch3_pull-request/src/app.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ch3_pull-request/src/app.js b/ch3_pull-request/src/app.js index d2b448d1..ed478479 100644 --- a/ch3_pull-request/src/app.js +++ b/ch3_pull-request/src/app.js @@ -1,5 +1,14 @@ function toRomanNumerals(num) { - return num; + var lookup = { M:1000,CM:900,D:500,CD:400,C:100,XC:90,L:50,XL:40,X:10,IX:9,V:5,IV:4,I:1 }; + var roman = ''; + var i; + for ( i in lookup ) { + while ( num >= lookup[i] ) { + roman += i; + num -= lookup[i]; + } + } + return roman; } var numbers = [3,4,5,13,42,2021];