fix(ui): sync provider when selecting cross-provider model#2860
Closed
dpshde wants to merge 1 commit intotailcallhq:mainfrom
Closed
fix(ui): sync provider when selecting cross-provider model#2860dpshde wants to merge 1 commit intotailcallhq:mainfrom
dpshde wants to merge 1 commit intotailcallhq:mainfrom
Conversation
Ensure :model cannot persist an invalid provider/model pair when the selected model belongs to a different provider. This keeps session routing consistent with the chosen model and avoids misleading upstream errors.
|
|
Contributor
|
There were several places this issue could have been caused. With the latest changes, the model selection prompt now appears every time a user logs in. We also removed the separate provider selection, since both the model and provider can now be chosen directly through model selection. Closing in favour of #2803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:modelselects a model owned by a different providerfireworks-ai + glm-5.1Problem
Forge allowed cross-provider model selection from the all-provider model picker, but only persisted the new model. That made it possible to save impossible session state such as:
This caused confusing routing and misleading upstream errors because the selected model and active provider no longer matched.
Fix
When
:modelselects a model from another provider, resolve that model's owning provider and activate it before finalizing the model selection.Verification
Related
Closes #2859