GH-49503: [Docs][Python] Documenting .pxi doctests are tested via lib.pyx#49515
GH-49503: [Docs][Python] Documenting .pxi doctests are tested via lib.pyx#49515AlenkaF merged 3 commits intoapache:mainfrom
Conversation
|
|
|
|
|
@github-actions crossbow submit preview-docs |
|
Revision: ecff1a1 Submitted crossbow builds: ursacomputing/crossbow @ actions-bfd9f4b8a6
|
AlenkaF
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Adding one comment from my side.
|
@AlenkaF thanks for the comment, addressed! |
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 8a8e574. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Running
python -m pytest --doctest-cythondirectly on.pxifiles doesn't work because Cython.pxifiles are included in.pyxfiles at compile time. This isn't documented, which could potentially confuse contributors.Please see discussion in #49279 (comment) by @AlenkaF for additional context.
What changes are included in this PR?
Added a
noteto the Doctest section of the Developing PyArrow documentation explaining that:.pxifiles cannot be tested directly with--doctest-cython.pyxfile they are included in (e.g.,lib.pyx).pyxfile, not the original.pxifilenameAre these changes tested?
Documentation-only change. No code changes.
Are there any user-facing changes?
No.