review

Author: smiklosovic

cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/JobInfo.java

@@ -70,6 +70,11 @@ default String getId()
 
     boolean skipExtendedVerify();
 
+    /**
+     * Defaults to false, in that case, when a row violates a constraint, a job will fail.
+     *
+     * @return true if rows violating constraints will not fail a job, false otherwise
+     */
     boolean skipRowsViolatingConstraints();
 
     boolean getSkipClean();

cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SortedSSTableWriter.java

@@ -148,7 +148,7 @@ public void addRow(BigInteger token, Map<String, Object> boundValues) throws IOE
         }
         catch (Throwable t)
         {
-            if (t.getCause() != null && t.getCause().getClass().getName().equals("org.apache.cassandra.cql3.constraints.ConstraintViolationException"))
+            if (t.getCause() != null && "org.apache.cassandra.cql3.constraints.ConstraintViolationException".equals(t.getCause().getClass().getName()))
             {
                 rowsViolatedConstraints += 1;
                 if (!skipRowsViolatingConstraints)

cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/MockBulkWriterContext.java

@@ -259,6 +259,12 @@ public boolean skipExtendedVerify()
         return false;
     }
 
+    @Override
+    public boolean skipRowsViolatingConstraints()
+    {
+        return false;
+    }
+
     @Override
     public boolean getSkipClean()
     {