address copilot comments

Author: sudo87

api/src/main/java/org/apache/cloudstack/api/response/LoginCmdResponse.java

@@ -91,7 +91,7 @@ public class LoginCmdResponse extends AuthenticationCmdResponse {
     private String managementServerId;
 
     @SerializedName(value = ApiConstants.PASSWORD_CHANGE_REQUIRED)
-    @Param(description = "Is User required to change password on next login.", since = "4.23.0")
+    @Param(description = "Indicates whether the User is required to change password on next login.", since = "4.23.0")
     private String passwordChangeRequired;
 
     public String getUsername() {

api/src/main/java/org/apache/cloudstack/api/response/UserResponse.java

@@ -133,7 +133,7 @@ public class UserResponse extends BaseResponse implements SetResourceIconRespons
     ApiConstants.ApiKeyAccess apiKeyAccess;
 
     @SerializedName(value = ApiConstants.PASSWORD_CHANGE_REQUIRED)
-    @Param(description = "Is User required to change password on next login.", since = "4.23.0")
+    @Param(description = "Indicates whether the User is required to change password on next login.", since = "4.23.0")
     private Boolean passwordChangeRequired;
 
     @Override
@@ -323,7 +323,7 @@ public void setApiKeyAccess(Boolean apiKeyAccess) {
     }
 
     public Boolean isPasswordChangeRequired() {
-        return passwordChangeRequired;
+        return Boolean.TRUE.equals(passwordChangeRequired);
     }
 
     public void setPasswordChangeRequired(Boolean passwordChangeRequired) {

plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java

@@ -285,11 +285,10 @@ public ListResponse<? extends BaseResponse> listApis(User user, String name) {
 
             // Limit APIs on first login requiring password change
             UserAccount userAccount = accountService.getUserAccountById(user.getId());
-            if (MapUtils.isNotEmpty(userAccount.getDetails()) &&
-                    userAccount.getDetails().containsKey(UserDetailVO.PasswordChangeRequired)) {
-
-                String needPasswordChange = userAccount.getDetails().get(UserDetailVO.PasswordChangeRequired);
-                if ("true".equalsIgnoreCase(needPasswordChange)) {
+            Map<String, String> userAccDetails = userAccount.getDetails();
+            if (MapUtils.isNotEmpty(userAccDetails)) {
+                String needPwdChangeStr = userAccDetails.get(UserDetailVO.PasswordChangeRequired);
+                if ("true".equalsIgnoreCase(needPwdChangeStr)) {
                     apisAllowed = Arrays.asList("login", "logout", "updateUser", "listUsers", "listApis");
                 }
             } else {

server/src/main/java/com/cloud/api/ApiServer.java

@@ -1230,7 +1230,7 @@ private ResponseObject createLoginResponse(HttpSession session) {
                 if (ApiConstants.MANAGEMENT_SERVER_ID.equalsIgnoreCase(attrName)) {
                     response.setManagementServerId(attrObj.toString());
                 }
-                if (PASSWORD_CHANGE_REQUIRED.endsWith(attrName)) {
+                if (PASSWORD_CHANGE_REQUIRED.equalsIgnoreCase(attrName)) {
                     response.setPasswordChangeRequired(attrObj.toString());
                 }
             }
@@ -1333,11 +1333,11 @@ public ResponseObject loginUser(final HttpSession session, final String username
             final String sessionKey = Base64.encodeBase64URLSafeString(sessionKeyBytes);
             session.setAttribute(ApiConstants.SESSIONKEY, sessionKey);
 
-            if (!MapUtils.isEmpty(userAcct.getDetails())) {
-                String needPwdChangeStr = userAcct.getDetails().getOrDefault(UserDetailVO.PasswordChangeRequired, null);
-                if (needPwdChangeStr != null) {
-                    boolean needPwdChange = "true".equalsIgnoreCase(needPwdChangeStr);
-                    session.setAttribute(PASSWORD_CHANGE_REQUIRED, needPwdChange);
+            Map<String, String> userAccDetails = userAcct.getDetails();
+            if (MapUtils.isNotEmpty(userAccDetails)) {
+                String needPwdChangeStr = userAccDetails.get(UserDetailVO.PasswordChangeRequired);
+                if ("true".equalsIgnoreCase(needPwdChangeStr)) {
+                    session.setAttribute(PASSWORD_CHANGE_REQUIRED, true);
                 }
             }
             return createLoginResponse(session);

server/src/main/java/com/cloud/user/AccountManagerImpl.java

@@ -1590,7 +1590,7 @@ private void updatePasswordChangeRequired(User caller, UpdateUserCmd updateUserC
         if (StringUtils.isNotBlank(updateUserCmd.getPassword()) && isNormalUser(user.getAccountId())) {
             boolean isPasswordResetRequired = updateUserCmd.isPasswordChangeRequired();
             // Admins only can enforce passwordChangeRequired for user
-            if ((isRootAdmin(caller.getId()) || isDomainAdmin(caller.getAccountId()))) {
+            if ((isRootAdmin(caller.getAccountId()) || isDomainAdmin(caller.getAccountId()))) {
                 if (isPasswordResetRequired) {
                     _userDetailsDao.addDetail(user.getId(), PasswordChangeRequired, "true", false);
                 }

ui/src/views/iam/ChangeUserPassword.vue

@@ -143,7 +143,7 @@ export default {
           params.currentpassword = values.currentpassword
         }
 
-        if (this.isAdminOrDomainAdmin && values.passwordChangeRequired) {
+        if (this.isAdminOrDomainAdmin() && values.passwordChangeRequired) {
           params.passwordchangerequired = values.passwordChangeRequired
         }
         postAPI('updateUser', params).then(json => {

ui/src/views/iam/ForceChangePassword.vue

@@ -127,10 +127,10 @@ export default {
   computed: {
     rules () {
       return {
-        currentpassword: [{ required: true, message: this.$t('message.error.current.password') || 'Please enter current password' }],
-        password: [{ required: true, message: this.$t('message.error.new.password') || 'Please enter new password' }],
+        currentpassword: [{ required: true, message: this.$t('message.error.current.password') }],
+        password: [{ required: true, message: this.$t('message.error.new.password') }],
         confirmpassword: [
-          { required: true, message: this.$t('message.error.confirm.password') || 'Please confirm new password' },
+          { required: true, message: this.$t('message.error.confirm.password') },
           { validator: this.validateTwoPassword, trigger: 'change' }
         ]
       }
@@ -250,7 +250,7 @@ export default {
   margin-top: 16px;
 
   a {
-    color: #1890ff; /* Ant Design Link Color */
+    color: #1890ff;
     transition: color 0.3s;
 
     &:hover {