Skip to content

Commit fcabb0c

Browse files
Apply suggestions from code review
Address Wei's reviews Co-authored-by: Wei Zhou <weizhou@apache.org>
1 parent beeb8ff commit fcabb0c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

engine/schema/templateConfig.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function getChecksum() {
5353
}
5454

5555
function createMetadataFile() {
56-
local fileData=$(cat $SOURCEFILE)
56+
local fileData=$(cat "$SOURCEFILE")
5757
echo -e "["default"]\nversion = $VERSION.${securityversion}\n" >> "$METADATAFILE"
5858
for template in "${templates[@]}"
5959
do
@@ -78,8 +78,8 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm
7878
"ovm3:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-ovm.raw.bz2" )
7979

8080
PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/"
81-
mkdir -p $PARENTPATH
81+
mkdir -p "$PARENTPATH"
8282
METADATAFILE="${PARENTPATH}metadata.ini"
8383
echo > "$METADATAFILE"
84-
SOURCEFILE=${PARENTPATH}'md5sum.txt'
84+
SOURCEFILE="${PARENTPATH}md5sum.txt"
8585
createMetadataFile

0 commit comments

Comments
 (0)