[MINDEXER-225] Indexer-reader handles classNames differently to JarFileContentsIndexCreator

[jira-importer]

Emeric Werner opened MINDEXER-225 and commented

The indexer-reader RecordCompactor and RecordExpander classes separate individual entries of the classNames entry using the field separator | (see

maven-indexer/indexer-reader/src/main/java/org/apache/maven/index/reader/RecordExpander.java

Line 212 in 87627e0

target.put(targetName, FS_PATTERN.split(value));

). However, the JarFileContentsIndexCreator class in indexer-core uses newlines (\n) as a separator between classes as seen in

maven-indexer/indexer-core/src/main/java/org/apache/maven/index/creator/JarFileContentsIndexCreator.java

Line 166 in 87627e0

sb.append(name, 0, name.length() - 6).append('\n');

. The behaviour of indexer-core with it's JarFileContentsIndexCreator is the behaviour I am empirically seeing in the wild with sample nexus-maven-repository-index.gz files.

Of course, one can still pass all the contents in a String whose elements were joined with the newline character ahead of time - but at that point it makes little sense why a String array needs to be passed as Record's value as it will almost always be a String-array of size 1 anyways (on a similar note, the documentation states that the classNames entry stores a value of type java.util.List<String>, but that is incorrect - it is a String[]).

---

Affects: 7.1.3